From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758454AbcAKG0S (ORCPT ); Mon, 11 Jan 2016 01:26:18 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:44341 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757356AbcAKG0P (ORCPT ); Mon, 11 Jan 2016 01:26:15 -0500 X-AuditID: cbfec7f5-f79b16d000005389-0a-56934b037c85 Subject: Re: [rtc-linux] [PATCH 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 To: Lee Jones References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-3-git-send-email-ldewangan@nvidia.com> <20160111054627.GB3331@x1> Cc: rtc-linux@googlegroups.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, swarren@nvidia.com, treding@nvidia.com, Laxman Dewangan , Chaitanya Bandi , Mallikarjun Kasoju From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56934AFD.5060008@samsung.com> Date: Mon, 11 Jan 2016 15:26:05 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <20160111054627.GB3331@x1> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsVy+t/xq7rM3pPDDH5dsbZYcvEqu0XHtcVM FnNPdLBZTH34hM1i/pFzrBb9bxayWpx79YgFSKxktHj9wtBi6b7VLBb3vx5ltPh2pYPJYsqf 5UwWm+f/YbS4vGsOm8XS6xeZLO7tXcFmMWH6WhaL1r1H2C32d3YwWtyY3sJqcfs3n4OYx5p5 axg9Lvf1Mnk82XSR0WPnrLvsHnsmnmTzWLn8C5vHplWdbB53ru1h8+htfsfm0bdlFaPH9Hk/ mTw+b5IL4InisklJzcksSy3St0vgyti+sZW1YANPRdf5PUwNjFO5uhg5OSQETCQufD/MBmGL SVy4tx7I5uIQEljKKHG18ygTSEJI4CmjxLJ3yiC2sEC0xJ4NJ4GKODhEBFQkzr0xh6h/zCix as1cRpAaZoElLBJ3d9iD2GwCxhKbly+BWiAn0ds9iQXE5hXQkvh8YCmYzSKgKtGx8i7YTFGB CIlFOzIhSgQlfky+B1bCKaAu8WTKBmaQEmYge8qUXIhN8hKb17xlnsAoOAtJxyyEqllIqhYw Mq9iFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECInnrzsYlx6zOsQowMGoxMM7Y9ekMCHWxLLi ytxDjBIczEoivK0ck8OEeFMSK6tSi/Lji0pzUosPMUpzsCiJ887c9T5ESCA9sSQ1OzW1ILUI JsvEwSnVwMjz6TGnxMz/bJk/7zza86fl5VG5DdaxJ8oni7eJFPJ5R4t9/bPDaOnLE9ffyNT2 7BZq5g34JNz0V8hDZY7cnZ7ls+6Y/ds37XcRi+e/6HmGb8Ve5xxccuD55m/md1edOJr66Xm9 0rnTEYIHnpyT2s5afnHN4l9HWSPvMm+bIHa73XpNdHLDxr0OSizFGYmGWsxFxYkAz92TlOMC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.01.2016 14:46, Lee Jones wrote: > On Fri, 08 Jan 2016, Krzysztof Kozlowski wrote: > > Thanks for taking the time to review. > >> ()2016-01-07 23:38 GMT+09:00 Laxman Dewangan : >>> MAX77620/MAX20024 are Power Management IC from the MAXIM. >>> It supports RTC, multiple GPIOs, multiple DCDC and LDOs, >>> watchdog, clock etc. >>> >>> Add MFD drier to provides common support for accessing the >>> device; additional drivers is developed on respected subsystem >>> in order to use the functionality of the device. >>> >>> Signed-off-by: Laxman Dewangan >>> Signed-off-by: Chaitanya Bandi >>> Signed-off-by: Mallikarjun Kasoju >>> Tested-by: Venkat Reddy Talla >> >> The Testing and Reviewed are statements (see SubmittingPatches) so >> they should be made explicitly by people. As this is v1 how they could >> make a public statement so far? > > SubmittingPatches bears no mention that Reviewed-by/Tested-by > statements have to be provided on one of the public mailing lists. > These can be provided privately prior to upstream submission v1. Indeed the document does not mention that they have to be provided by public. In the same time these are statements given by a reviewer ("By offering my Reviewed-by: tag, I state that:")... and how can you validate a statement given through a private channel? Is it true? Is it a thorough testing or just copy-paste from Gerrit (or other automated system)? Best regards, Krzysztof