From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759309AbcAKK2W (ORCPT ); Mon, 11 Jan 2016 05:28:22 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:60926 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758556AbcAKK2U (ORCPT ); Mon, 11 Jan 2016 05:28:20 -0500 Subject: Re: Correct place for USB PHY driver To: Mason , Felipe Balbi References: <56937EC9.4050109@free.fr> CC: LKML , linux-usb , Arnd Bergmann From: Kishon Vijay Abraham I Message-ID: <569383BB.3030400@ti.com> Date: Mon, 11 Jan 2016 15:58:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56937EC9.4050109@free.fr> Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hI, On Monday 11 January 2016 03:37 PM, Mason wrote: > Hello, > > I have a board with a Chipidea controller. > I use a custom PHY driver for it. > > Should the PHY driver live in drivers/phy or in drivers/usb/phy ? All new phy drivers should be in drivers/phy using the generic PHY framework. > > I was playing with a modular build and hit this problem: > ERROR: "of_usb_get_phy_mode" [drivers/usb/chipidea/ci_hdrc.ko] undefined! > > I'm currently using v4.1.13 and I saw that Arnd fixed something related > probably in a later version: > > http://thread.gmane.org/gmane.linux.ports.arm.kernel/457561 > > Was this patch accepted upstream? I think no. Thanks Kishon