From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759047AbcAKL4i (ORCPT ); Mon, 11 Jan 2016 06:56:38 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:40314 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbcAKL4g (ORCPT ); Mon, 11 Jan 2016 06:56:36 -0500 Subject: Re: Correct place for USB PHY driver To: Kishon Vijay Abraham I , Felipe Balbi Cc: LKML , linux-usb , Arnd Bergmann References: <56937EC9.4050109@free.fr> <569383BB.3030400@ti.com> From: Mason Message-ID: <5693986B.6050204@free.fr> Date: Mon, 11 Jan 2016 12:56:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 MIME-Version: 1.0 In-Reply-To: <569383BB.3030400@ti.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/2016 11:28, Kishon Vijay Abraham I wrote: > On Monday 11 January 2016 03:37 PM, Mason wrote: > >> I have a board with a Chipidea controller. >> I use a custom PHY driver for it. >> >> Should the PHY driver live in drivers/phy or in drivers/usb/phy ? > > All new phy drivers should be in drivers/phy using the generic PHY framework. > >> I was playing with a modular build and hit this problem: >> ERROR: "of_usb_get_phy_mode" [drivers/usb/chipidea/ci_hdrc.ko] undefined! >> >> I'm currently using v4.1.13 and I saw that Arnd fixed something related >> probably in a later version: >> >> http://thread.gmane.org/gmane.linux.ports.arm.kernel/457561 >> >> Was this patch accepted upstream? > > I think no. The driver I use is in drivers/phy and my config has CONFIG_GENERIC_PHY=y # CONFIG_USB_PHY is not set But I do hit the "of_usb_get_phy_mode undefined" error when I set all of USB to m. Arnd, do you think your patch needs to be carried over to generic PHY? Regards.