From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759676AbcAKNik (ORCPT ); Mon, 11 Jan 2016 08:38:40 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:35371 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759465AbcAKNih (ORCPT ); Mon, 11 Jan 2016 08:38:37 -0500 Subject: Re: [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s for kylin board To: Heiko Stuebner References: <1452155155-16232-1-git-send-email-wxt@rock-chips.com> <1452155155-16232-4-git-send-email-wxt@rock-chips.com> <1878139.nbddSBf70A@phil> Cc: Caesar Wang , Mark Rutland , devicetree@vger.kernel.org, Ulf Hansson , Russell King , Pawel Moll , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , leecam@google.com, linux-arm-kernel@lists.infradead.org, keescook@google.com, leozwang@google.com From: Caesar Wang Message-ID: <5693B056.7010507@gmail.com> Date: Mon, 11 Jan 2016 21:38:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1878139.nbddSBf70A@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Heiko, 在 2016年01月09日 10:31, Heiko Stuebner 写道: > Hi Caesar, > > Am Donnerstag, 7. Januar 2016, 16:25:46 schrieb Caesar Wang: >> The sysclk seems be incorrect since we use the simple card for kylin >> board. >> >> The simple card call: >> >> asoc_simple_card_probe -> >> asoc_simple_card_dai_link_of -> >> asoc_simple_card_sub_parse_of -> >> ... >> clk = of_clk_get(args.np, 0); >> if (!IS_ERR(clk)) >> dai->sysclk = clk_get_rate(clk); >> >> The sysclk come from the first clock, then first clock is hclk_i2s >> in i2s for rk3036 dtsi. >> So, we can override the clocks to fit the simple card in here. > It's not that effective, doing that change on a per-board level - as it > would possibly need to be repeated for future boards. > The i2s driver doesn't care, as it uses named clocks, so I instead did > the swap in the rk3036.dtsi for all boards. Can you check if that is ok > for you or if I did overlook something? That's okay for me. > > Thanks > Heiko > > ------- 8< ------- > Subject: [PATCH] ARM: dts: rockchip: swap i2s clock ordering on rk3036 > > For sound setups using the simple-card mechanism, the main clock > (sysclk) is expected to be the first element. For the i2s-driver > itself it doesn't matter, as it uses named clocks, so we can just > swap them. > > Reported-by: Caesar Wang > Signed-off-by: Heiko Stuebner > --- > arch/arm/boot/dts/rk3036.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi > index 8f1bb0f..ee457a2 100644 > --- a/arch/arm/boot/dts/rk3036.dtsi > +++ b/arch/arm/boot/dts/rk3036.dtsi > @@ -241,8 +241,8 @@ > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > - clock-names = "i2s_hclk", "i2s_clk"; > - clocks = <&cru HCLK_I2S>, <&cru SCLK_I2S>; > + clock-names = "i2s_clk", "i2s_hclk"; > + clocks = <&cru SCLK_I2S>, <&cru HCLK_I2S>; > dmas = <&pdma 0>, <&pdma 1>; > dma-names = "tx", "rx"; > pinctrl-names = "default"; -- Thanks, Caesar