From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760486AbcAKPCW (ORCPT ); Mon, 11 Jan 2016 10:02:22 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:42586 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759832AbcAKPCU (ORCPT ); Mon, 11 Jan 2016 10:02:20 -0500 Subject: Re: [PATCH v3 0/2] adding PCI support to AXS10x To: Bjorn Helgaas , Joao Pinto References: <20160108203358.GI5354@localhost> <5693BCD7.4050703@synopsys.com> <20160111145353.GD25540@localhost> CC: , , , , , , , , , , From: Joao Pinto Message-ID: <5693C3F4.6040408@synopsys.com> Date: Mon, 11 Jan 2016 15:02:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160111145353.GD25540@localhost> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.13.184.19] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I am going to add dependencies to the driver' kconfig to avoid this problem. I will send you a new patch version today. Thanks. On 1/11/2016 2:53 PM, Bjorn Helgaas wrote: > On Mon, Jan 11, 2016 at 02:31:51PM +0000, Joao Pinto wrote: >> Hi Bjorn, >> >> On 1/8/2016 8:33 PM, Bjorn Helgaas wrote: >>> Hi Joao, >>> >>> On Mon, Dec 21, 2015 at 03:44:14PM +0000, Joao Pinto wrote: >>>> This patch set has the goal to add suppport for DesignWare PCIe RC in ARC >>>> AXS10x. It includes the necessary tweaks to the ARC architecture, necessary >>>> tweaks to the PCI subsystem and a new driver (pcie-snpsdev). >>>> This new driver will be used extensively in the PCIe RC Prototyping Kit. >>>> >>>> The patches were produced against Bjorn Helgaas' repository. It was properly >>>> tested in an IP Prototyping Kit. >>>> >>>> Joao Pinto (2): >>>> PCI support added to ARC >>>> add new platform driver for PCI RC >>>> >>>> .../devicetree/bindings/pci/pcie-snpsdev.txt | 33 +++ >>>> MAINTAINERS | 7 + >>>> arch/arc/Kconfig | 23 ++ >>>> arch/arc/include/asm/dma.h | 5 + >>>> arch/arc/include/asm/io.h | 10 + >>>> arch/arc/include/asm/pci.h | 43 ++++ >>>> arch/arc/kernel/Makefile | 1 + >>>> arch/arc/kernel/pcibios.c | 55 ++++ >>>> arch/arc/mm/ioremap.c | 10 +- >>>> arch/arc/plat-axs10x/Kconfig | 1 + >>>> drivers/pci/Makefile | 1 + >>>> drivers/pci/host/Kconfig | 5 + >>>> drivers/pci/host/Makefile | 1 + >>>> drivers/pci/host/pcie-designware.c | 11 + >>>> drivers/pci/host/pcie-designware.h | 1 + >>>> drivers/pci/host/pcie-snpsdev.c | 286 +++++++++++++++++++++ >>>> 16 files changed, 492 insertions(+), 1 deletion(-) >>>> create mode 100644 Documentation/devicetree/bindings/pci/pcie-snpsdev.txt >>>> create mode 100644 arch/arc/include/asm/pci.h >>>> create mode 100644 arch/arc/kernel/pcibios.c >>>> create mode 100644 drivers/pci/host/pcie-snpsdev.c >>> >>> This failed the kbuild test, so I'm waiting for a refresh to fix that. >> >> Just checked the kbuild robot error and it is happening in ARC git tree when >> built for i386 arch and the problem is independent from my patches. The build >> error is the following: >> >> drivers/pci/host/pcie-designware.c: In function 'dw_pcie_host_init': >>>> drivers/pci/host/pcie-designware.c:556:7: error: implicit declaration of function >> 'pci_has_flag' [-Werror=implicit-function-declaration] >> if (!pci_has_flag(PCI_PROBE_ONLY)) { >> ^ >>>> drivers/pci/host/pcie-designware.c:556:20: error: 'PCI_PROBE_ONLY' undeclared >> (first use in >> this function) >> if (!pci_has_flag(PCI_PROBE_ONLY)) { >> ^ >> This problem has been already identified by Stephen Rothwell as you can see in >> the following mailing list thread: >> >> http://www.gossamer-threads.com/lists/linux/kernel/2341200 > > Stephen saw that problem while building the Qualcomm driver > (CONFIG_PCIE_QCOM), and we fixed it by changing Kconfig so we won't build > that driver on x86. > > That fix only affects CONFIG_PCIE_QCOM, so it won't help your driver. > > You need some improvements to your drivers/pci/host/Kconfig patch -- some > help text and probably some dependencies. > > Bjorn >