From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761344AbcAKQ6O (ORCPT ); Mon, 11 Jan 2016 11:58:14 -0500 Received: from mail-bn1on0054.outbound.protection.outlook.com ([157.56.110.54]:7745 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761326AbcAKQ6K (ORCPT ); Mon, 11 Jan 2016 11:58:10 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O0SSGR-07-A6U-02 X-M-MSG: Subject: Re: [PATCH] ata: add AMD Seattle platform driver To: Mark Langsdorf , Arnd Bergmann References: <1452200002-31590-1-git-send-email-brijesh.singh@amd.com> <4983521.tEaWggKCCv@wuerfel> <568F14E0.4060107@amd.com> <10869853.plxna0HzWE@wuerfel> <5690367E.8060609@amd.com> <5693CB41.70408@redhat.com> CC: , , , , , , , , , , From: Brijesh Singh Message-ID: <5693DE9A.9070101@amd.com> Date: Mon, 11 Jan 2016 10:55:54 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5693CB41.70408@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(3190300001)(199003)(377454003)(189002)(479174004)(24454002)(52604005)(65956001)(2950100001)(83506001)(65816999)(106466001)(47776003)(86362001)(189998001)(2906002)(76176999)(97736004)(54356999)(50986999)(87266999)(50466002)(33656002)(5001770100001)(4001350100001)(5004730100002)(64126003)(101416001)(105586002)(1220700001)(230700001)(1096002)(77096005)(36756003)(3846002)(6116002)(23746002)(92566002)(80316001)(586003)(93886004)(59896002)(4326007)(5008740100001)(87936001)(65806001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0716;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;2:DWU+DuU15CwDf8iOHGtPAzGrZ/vElwnIYz5Bq3OnW9/mugMISqVBeBCJVkPuhHcQmnp/b+KpyyUKdFLEO+a6QkQeMXgz7ApjoeaiC3mrrPqh7LOTuO6Ur1ITMaxtYLfPT9/uePYqpJGoT6ROVpxC+g==;3:x05M91t4f98RIwH9Vrsx3hE2QGrtEK/SjDVUo39IplPIVtrzlopxyjytABrBG1NJ9oc4ynC9texsjhgg6BsMc9536sX/g7MduM02no0kus2Y9IFX1WYXIa0n5BanziEZT0YuRdtFgmc3YMsC7g8EmxV3ukec1CufbJ1zPbnZdJq7a3zHq8sUdtwQmfXRU4RrenalsYSi0dZHqCyZIefZstNsmJ2wXcirpGIrXmKXk4k=;25:0eHEiPymT0Fn1zjs7P4vso8x7j5BEhL/svHYAnGmMxOLVEXtS7Z/UcaSBx7uROcUgN7iu6tMk7KjheK5VHAGBUkoqkuycx3W/i8wyOVG0zP9Sm1rT9Okpmnzy8cn04F2mIF3CIJZuTPF0o4PxuEjIGQM975j1cHoPDYcg6An0b1KkIabxloIX9cGRYRl+uEn1EF4SyRdCoMf1Ny1OwjMZNuS+M7X3yFpXEDdaLSDv1mm/+vHaWn71MXrx68O0xrp X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0716; X-MS-Office365-Filtering-Correlation-Id: 56615c45-f001-45db-03ab-08d31aa8608d X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;20:iAcS11MjZJNH5dG4pcvaSkH1et9Tjn0xlGhUQFUkGs59O+TwwDxuA24bjOdoKUNl3MEGVWoYu4EK6LehRi1GRX25VLzqmsjOm/qW4Ll26wBI78kkPaLzJ0kafVtUDbFliUw4q9A6d2zLE2F0HE3bhrJ3AuZuA2y4FimysezRUZHYv8x0NV+RAmsrgv57etxUwYkg9Vz/Kye1hG5GuLG3lrWUXX/TWQ6aCCTKh4C/qZset56QdQo70Hg174mwxpY5vJqRbRlYeTV42I4Vot5joXPyDfjMmFJMG4ZceUdpCHgYeHZTe0nYKLP1pHsjU8G8a7/o7udBTUsTvc9UHe/10irfFI19Q4et4m9YbUnJizQhSstw9XzTCj8VYdshD6TZEUn0ZvNzqfU0BUB80fO7m4Lf3kiKIOpXdNDMwceFrpx8vWNxoyZy6PCBW+Pb7j4w064kYp29iNbIfvYWhHj6nDa01qM+DxTx8BPU5hXv/6pvxffVbDWO0DSzmX0K78hY;4:8Q5MgiyBB7KTYUuXfyf4YzEXlIpf5HZCkGDi0MZlwWiCUxZrNbATUDZo8024YOH1B//ge95rUskWoXtb/8RlMaq3dm5r/UfloKnZdisBdfkm0VQ1Z2VxUB02uc+vu6h2FTwIECknYKyiWRA2z3Pm2XZ/E366JIRQtMc0K7Jzzo0hLCZLA9T2hwA2DToBJZYzNGDZ9Q81f+hZ5nLRAhX7v+2ZDMVSDtz47oreCVLUQnbNvYwDqiDEUUZaSaAypQfJmIG0C0N0q07VtjeFAihrD9hgM7j3vk3DOJdPpE2OGu59mSvCfmYR7Drw9X8ykAr1qxnviMR5glOecwjVKS7ZzZVIOa0ablpOUzembscK0BS2fLU0jw7UD3GCgkWrnABZdPGeLzLzBqNsNZdAWL+0Lo7J4yQPlbJM1O0M5ywZqFKqoHkZK3NQIGpYXX3du2WB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13017025)(13015025)(5005006)(13018025)(8121501046)(520078)(10201501046)(3002001);SRVR:CY1PR12MB0716;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0716; X-Forefront-PRVS: 0818724663 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR12MB0716;23:qC8fCdCvKH54ieulhj7vTgco5zEPEy2N0awjo?= =?Windows-1252?Q?14W7lIFP+LlalKJjZ2W35hvJ2pVdqK41lb9wgvdh4CD5kSV9oLKlrpbL?= =?Windows-1252?Q?/HZEyAJZW/cQQGt7dX9O1anIsl8HISDGORczZ/pHPPk/VgFhqeeuJgLz?= =?Windows-1252?Q?ya5PFu0zs4XtZc4bZnqzAKer5txLDNfr7by42vgEliOEBRM5f5YAiI0Y?= =?Windows-1252?Q?PhcpUei0NS7+vYxb3hAn3YVBZbnp+ALkJ1P2q5Ot4EbExiIhzPnC6DDb?= =?Windows-1252?Q?xSD6En1XQJ861o93SRC1KmUCUEC26UgaBKRZCMz3vI+zpUf4ohVxqDpV?= =?Windows-1252?Q?cGWX1JmQa3IyevFqN6Kc/80vE/EnorFyt8kPm1haueQ58fkXRUhi5JdM?= =?Windows-1252?Q?4t4Qn8MC2wds2cMQIZ264z3qdtyp0/bHu6B51UP6ovgHEwHFtmOuQYB1?= =?Windows-1252?Q?L59ZZ5BfbPpMR6yNdnA4eU/BsRrxmfALER7+uorOkJdqX6jOITeYhFV+?= =?Windows-1252?Q?ygi/8I1DdKMS3hpiP+gKGCB4TeJTWCO27NzytDmC3sbqp9YZtjKQ1YP/?= =?Windows-1252?Q?L0+Wq8rMNNouzcQbypJrBb1aO7Tv5aBEpq1syMY1j8c4UrpHYQoEP0OF?= =?Windows-1252?Q?AuhUCJsvU3H6Jlh8RkEXPyvaOjUAmSDc+6Nav6+y23JtMvvBcs5nzDMw?= =?Windows-1252?Q?MPqCTacAB0ApI5adgPWz1c4qhDj/hdDKJFS0J8F09GnP3Ozw0GbPcip9?= =?Windows-1252?Q?80a0UlF1SbMLcYzLsoWX7aKQ5xu6hy876OSdqRrYn2COG9gHG94BjpiZ?= =?Windows-1252?Q?o6JG3YB3AK/pM03wux2VLPiRAz0idYxCW3ezsUv4Kvc8KY2PDwjo9zXJ?= =?Windows-1252?Q?0PuVhpjt1z6dLMAf7QKbEisuTaOADM6jDOcddm2R9ikJOLY3CZwLCPLP?= =?Windows-1252?Q?5QHp5ZJwGwDpR2ucamgDOqSYGBC2LP3YK+rYu1jDyK0ErSja2UkQGiqB?= =?Windows-1252?Q?oAP0Mq8MiNeKQNuQSlLWlI4JUI56IJPvl70i5vMZzQ6xi0t/4GC1MP3p?= =?Windows-1252?Q?bDHV7vo+8PbxXhClDYUyw4PABGixajZ3OD3C9t/HJghBpm+tT9hkwcNs?= =?Windows-1252?Q?vNjqWZ5dfBzNWD/iMMtnNv04wiJiCSQJeJILaKNU8CoRHE+rVmLbGhkZ?= =?Windows-1252?Q?h8UKUcTfsUDhF4YaxuzQDv/a2Y12AN15woHAwNRE3LRt0HpvkJs7MOP2?= =?Windows-1252?Q?EH1+r7BX2y35X5nvS4bhFZnPXkt03+dx8Nfz7Ueh80pZAO4B0Luxci/6?= =?Windows-1252?Q?eRoW/O6rg6FWkrit4UhqdZ6W/2ttoycbi5ZxV9mOuf4PaA=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;5:5As3IzhMfQF3D9+ERBP029zNE2qAX4lb3xTKIZt9xw7dYzcbrWEUZiOwjG+6byCJaVnORybT5AOie0+eCU4r3jKFvzbxGnUupHcX5/mtDLIOx3ntmn4ZIQzmQxxQaLbWYBxgVs1tRwb1bkHZIjeb8A==;24:ghacZUfi5CPlTzK5Ugo0CXDWePhD4b6YxwAXHeVUvQIOinUYIrR4qSEi68WUORGBVtgXl1ZEghDT6g9y0O4dxH0KaOZG3OGnYCWV6fc6Ks0=;20:aDZzgVNX/D9Ma72LjRIhlJ1uODwExo1Xs0X/3zyBlLuJkQmcYeEunKmrLttv0+RDUMjOt7YAEG+pOjt8j9MtvJNz9R1W7tWAZMqbNNKyLt5JvEChQcWtwakD72yP/R4yWQLkrxjP8wA2aLaWKrkbiGTrRLbyt9JgC/jG3oqJkXDMsuxraQCi1ocMg73nXOqpoiC932m/wAHmowp0N68dmHSjgtnnD9ryMgTDIcg1+5SlnbkBdJrddq5IgRHfrbWP SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2016 16:58:05.6522 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0716 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01/11/2016 09:33 AM, Mark Langsdorf wrote: > On 01/08/2016 04:21 PM, Brijesh Singh wrote: >> >> libata-*.c implements the "Enclosure management" style led messages but also has hooks >> to register a custom led control callback. Since Seattle platform does not support >> the "Enclosure management" registers hence ata_port_info we are setting a ATA_FLAG_EM | ATA_FLAG_SW_ACIVITY >> to indicate that we can still handle the led messages by our registered callback. I see >> that sata_highbank driver is doing something similar. > > The sata_highbank driver is doing it wrong and shouldn't have been > accepted in its current condition. Enclosure management really should > be a separate device. Please don't use it as an example. > Okay. Thanks for letting me know. Should I consider extending the generic driver to handle this Seattle platform specific feature or go with a new platform driver approach (i.e the one I am doing right now) ? -Brijesh