From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934330AbcAKRcF (ORCPT ); Mon, 11 Jan 2016 12:32:05 -0500 Received: from smtp113.iad3a.emailsrvr.com ([173.203.187.113]:32797 "EHLO smtp113.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933885AbcAKRcA (ORCPT ); Mon, 11 Jan 2016 12:32:00 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] staging: comedi: dt2801: Prefer using the BIT macro To: Bhaktipriya Shridhar , hsweeten@visionengravers.com, gregkh@linuxfoundation.org, mahfouz.saif.elyazal@gmail.com References: <20160111160428.GA8839@Karyakshetra> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <5693E70D.7090909@mev.co.uk> Date: Mon, 11 Jan 2016 17:31:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160111160428.GA8839@Karyakshetra> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/16 16:04, Bhaktipriya Shridhar wrote: > As suggested by checkpatch.pl, this patch replaces bit shifting on 1 with the > BIT(x) macro. > > Signed-off-by: Bhaktipriya Shridhar > --- > drivers/staging/comedi/drivers/dt2801.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c > index 80e38de..6c7b4d2 100644 > --- a/drivers/staging/comedi/drivers/dt2801.c > +++ b/drivers/staging/comedi/drivers/dt2801.c > @@ -68,17 +68,17 @@ Configuration options: > /* Command modifiers (only used with read/write), EXTTRIG can be > used with some other commands. > */ > -#define DT_MOD_DMA (1<<4) > -#define DT_MOD_CONT (1<<5) > -#define DT_MOD_EXTCLK (1<<6) > -#define DT_MOD_EXTTRIG (1<<7) > +#define DT_MOD_DMA BIT(4) > +#define DT_MOD_CONT BIT(5) > +#define DT_MOD_EXTCLK BIT(6) > +#define DT_MOD_EXTTRIG BIT(7) > > /* Bits in status register */ > -#define DT_S_DATA_OUT_READY (1<<0) > -#define DT_S_DATA_IN_FULL (1<<1) > -#define DT_S_READY (1<<2) > -#define DT_S_COMMAND (1<<3) > -#define DT_S_COMPOSITE_ERROR (1<<7) > +#define DT_S_DATA_OUT_READY BIT(0) > +#define DT_S_DATA_IN_FULL BIT(1) > +#define DT_S_READY BIT(2) > +#define DT_S_COMMAND BIT(3) > +#define DT_S_COMPOSITE_ERROR BIT(7) > > /* registers */ > #define DT2801_DATA 0 > -- > 2.1.4 > Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-