From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934247AbcAKXjz (ORCPT ); Mon, 11 Jan 2016 18:39:55 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:54563 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761914AbcAKXjn (ORCPT ); Mon, 11 Jan 2016 18:39:43 -0500 Subject: Re: arm qemu boot failures in -next due to 'PM / Domains: add setter for dev.pm_domain' To: "Rafael J. Wysocki" References: <5693EB8A.40802@roeck-us.net> <20160111185459.GZ12777@atomide.com> <20160111200450.GA16902@roeck-us.net> <7302125.veLBHLkdLG@vostro.rjw.lan> Cc: Tony Lindgren , Tomeu Vizoso , Russell King , Kevin Hilman , linux-arm-kernel@lists.infradead.org, "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" From: Guenter Roeck Message-ID: <56943D3B.8010600@roeck-us.net> Date: Mon, 11 Jan 2016 15:39:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <7302125.veLBHLkdLG@vostro.rjw.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2016 02:49 PM, Rafael J. Wysocki wrote: > On Monday, January 11, 2016 12:04:50 PM Guenter Roeck wrote: >> On Mon, Jan 11, 2016 at 10:55:00AM -0800, Tony Lindgren wrote: >>> * Guenter Roeck [160111 09:51]: >>>> Hi, >>>> >>>> I see 6 out of 24 arm qemu tests failing in next-20160111. Bisect points >>>> to commit 989561de9b51 ("PM / Domains: add setter for dev.pm_domain"). >>>> Failures are silent - there is no output on the console. >>>> Affected tests are >>>> >>>> arm:beagle:multi_v7_defconfig:omap3-beagle >>>> arm:beaglexm:multi_v7_defconfig:omap3-beagle-xm >>>> arm:overo:multi_v7_defconfig:omap3-overo-tobi >>>> arm:beagle:omap2plus_defconfig:omap3-beagle >>>> arm:beaglexm:omap2plus_defconfig:omap3-beagle-xm >>>> arm:overo:omap2plus_defconfig:omap3-overo-tobi >>>> >>>> For details please see the 'next' column at http://server.roeck-us.net:8010/builders. >>>> >>>> Reverting the offending commit fixes the problems. >>>> >>>> Please let me know if there is anything I can do to help tracking down the problem. >>> >>> The following fixes the booting, but I wonder if it's a >> >> Yes, it does. >> >> Tested-by: Guenter Roeck >> >>> proper fix? >>> >> That I don't know. > > If I'm not mistaken, what happens is that device_is_bound() tries to > dereference dev->p which is NULL. If that's the case, the appended one > should help too. > > Can you please check? > > --- > drivers/base/dd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-pm/drivers/base/dd.c > =================================================================== > --- linux-pm.orig/drivers/base/dd.c > +++ linux-pm/drivers/base/dd.c > @@ -234,7 +234,7 @@ late_initcall(deferred_probe_initcall); > */ > bool device_is_bound(struct device *dev) > { > - return klist_node_attached(&dev->p->knode_driver); > + return dev->p && klist_node_attached(&dev->p->knode_driver); Yes, that fixes the problem as well. Guenter