From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751763AbcFVNsk (ORCPT ); Wed, 22 Jun 2016 09:48:40 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:61245 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbcFVNsj (ORCPT ); Wed, 22 Jun 2016 09:48:39 -0400 From: Arnd Bergmann To: Deepa Dinamani Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, tytso@mit.edu, viro@zeniv.linux.org.uk, y2038@lists.linaro.org, Artem Bityutskiy , Adrian Hunter , linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 07/24] fs: ubifs: Replace CURRENT_TIME_SEC with current_time Date: Wed, 22 Jun 2016 15:47:56 +0200 Message-ID: <5694616.oYyysJP9uD@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1466382443-11063-8-git-send-email-deepa.kernel@gmail.com> References: <1466382443-11063-1-git-send-email-deepa.kernel@gmail.com> <1466382443-11063-8-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Ow20aY+qldbllPnZFjblxc9v33KMlvPpw9GcQYELRUgbvrAdivJ czP9GOhgjNVv/6ypsfHBIxUybHYAA53lbMftG5EvBdZYDgFCc9d8s88fg9QJlaC83zsYh2C kNvVLr+z0EQW5qE3nqlbzBBsPyFctOnAULesc9KdhpPlb0ue5fH9SQzWieXEeNKPCi2udUV 9e6R0TI1/xepg2zD+d0yQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:wzV5Js/ycc8=:9geCU0L4HAop9HhYvjT41E m32NUyg0sK5kqUpZ0+AMwWx9zftg88WYEelVpeTWovVzsf9y1hRmJ6jq/gQUuf5pAzAxNTo/D SPJYSvz5EPH2GgixmZMW8ae8aGcWYNbYHUMhRRNr2+JONcjEbSelAOzhvdGV3TeBTqh0+z0y/ eJ2etAtPY53IMzSij4NJSMjD69zlUpTuKmrdknC4GxFyL9WxWyigdC811Hw5LJbqDx7eCJ24S s8P0n4V0SDp161gJTCDBxjl2WF8Z8muyjH82WXwpFdhhNA83Do/uO5nGaNtHsUArZduBE5tXz yecMXV/SnMO5tt8WH+RJ4t+RDtMynwFG4jCwwsr5VD/mr4eV6UndGfnrhtInoE4MowGuZFUHr 0U4bHcKIByR92U74YDyF+K2qlbrMGP9rvXtmBvjYeqRou/buH13L0dmBSUn5xhWkXHj3j9frA gmZpgiiNI5+Kj2CPrvtENyFe4L26oE0o61CNUmFaw1Gm03wZ248IJCY3uttwqcSghsJIX5EUY RKXhtg9iIieY3IisQiYFROmZRzm5I32oBzj/EGQUgmNQmh+ysTBm37KMvvKiRBfEpGHli1Hjs QI2ig+U85grSNafiiiTJtNViymUSv6ljkaSNa6ape++poCdTtnfL7uhgIQEU7E1CNZMofcy+s mpLFZa8U3McmlD5sS7HJ9olPgaghyAPETVqhABzErAVJXBLte1eu1YubM/DJyGSAaHLCTIdtf ZL0cORk5Hnxr6yr4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, June 19, 2016 5:27:06 PM CEST Deepa Dinamani wrote: > @@ -84,6 +84,8 @@ static int create_default_filesystem(struct ubifs_info *c) > int min_leb_cnt = UBIFS_MIN_LEB_CNT; > long long tmp64, main_bytes; > __le64 tmp_le64; > + __le32 tmp_le32; > + struct timespec ts; > > /* Some functions called from here depend on the @c->key_len filed */ > c->key_len = UBIFS_SK_LEN; > @@ -297,13 +299,17 @@ static int create_default_filesystem(struct ubifs_info *c) > ino->ch.node_type = UBIFS_INO_NODE; > ino->creat_sqnum = cpu_to_le64(++c->max_sqnum); > ino->nlink = cpu_to_le32(2); > - tmp_le64 = cpu_to_le64(CURRENT_TIME_SEC.tv_sec); > + > + ktime_get_real_ts(&ts); > + ts = timespec_trunc(ts, DEFAULT_TIME_GRAN); > + tmp_le64 = cpu_to_le64(ts.tv_sec); > ino->atime_sec = tmp_le64; > ino->ctime_sec = tmp_le64; > ino->mtime_sec = tmp_le64; > - ino->atime_nsec = 0; > - ino->ctime_nsec = 0; > - ino->mtime_nsec = 0; > + tmp_le32 = cpu_to_le32(ts.tv_nsec); > + ino->atime_nsec = tmp_le32; > + ino->ctime_nsec = tmp_le32; > + ino->mtime_nsec = tmp_le32; This part of the patch seems independent of the rest, as you don't actually use current_time() here, or assign the timespec to an inode. I'd suggest either leaving this part out of the patch series for now, or making it a separate patch that uses timespec64 directly. Arnd