From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760070AbcALH67 (ORCPT ); Tue, 12 Jan 2016 02:58:59 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:33261 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752208AbcALH66 (ORCPT ); Tue, 12 Jan 2016 02:58:58 -0500 Subject: Re: [PATCH v2 3/3] can: sja1000: of: add compatibility with Technologic Systems version To: Damien Riegel , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org References: <1450978973-30417-1-git-send-email-damien.riegel@savoirfairelinux.com> <1450978973-30417-4-git-send-email-damien.riegel@savoirfairelinux.com> Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Wolfgang Grandegger , kernel@savoirfairelinux.com From: Marc Kleine-Budde Message-ID: <5694B17A.10406@pengutronix.de> Date: Tue, 12 Jan 2016 08:55:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1450978973-30417-4-git-send-email-damien.riegel@savoirfairelinux.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wlwpQ0NMcjHgjD91eXgqct6bgA5qSkRQa" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wlwpQ0NMcjHgjD91eXgqct6bgA5qSkRQa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/24/2015 06:42 PM, Damien Riegel wrote: > Technologic Systems provides an IP compatible with the SJA1000, > instantiated in an FPGA. Because of some bus widths issue, access to > registers is made through a "window" that works like this: >=20 > base + 0x0: address to read/write > base + 0x2: 8-bit register value Why do you use io{read,write}16 if it's a 8 bit register? Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --wlwpQ0NMcjHgjD91eXgqct6bgA5qSkRQa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJWlLF6AAoJEP5prqPJtc/HgRgIAJ1DIQX3i2VMJagqfR+nMJKP G4P7W2U0/Ee6U2xs2bpdwr00GojJltUcrm5itiAacNWKEbhuuA7JLvjHyxLec5V2 m3xpCgie6lt+JEHL23wtGuxCQpo1AWsCDq9tt09ovZbKF3FvIR2Q8MR6rPpb6VUr A0OpiHr0b9r/oaGKCMDLqyJysQNe4WWz3PuMgExilmGMa7lkM4ls7UvLIJAXCKh5 YMDxhhgMdn6cmY/kQdcg7LbrJuYV84lPtaMVSJz2PIxPR60NmYGObDg9Cpz7B6By Wagb566V1XN7nv8LyvXk7ViRJjiOFdyZvHK7OxIfcRui9vB5X/qp42sFEscNA3w= =ZSMF -----END PGP SIGNATURE----- --wlwpQ0NMcjHgjD91eXgqct6bgA5qSkRQa--