From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965212AbcALLbU (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 06:31:20 -0500
Received: from hqemgate16.nvidia.com ([216.228.121.65]:5686 "EHLO
	hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933632AbcALLbQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 06:31:16 -0500
X-PGP-Universal: processed;
	by hqnvupgp07.nvidia.com on Tue, 12 Jan 2016 03:14:06 -0800
Message-ID: <5694E19A.2050107@nvidia.com>
Date: Tue, 12 Jan 2016 16:50:58 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Julia Lawall <julia.lawall@lip6.fr>
CC: <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <linus.walleij@linaro.org>, <gnurou@gmail.com>, <lee.jones@linaro.org>,
        <broonie@kernel.org>, <a.zummo@towertech.it>,
        <alexandre.belloni@free-electrons.com>, <lgirdwood@gmail.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <rtc-linux@googlegroups.com>,
        <swarren@nvidia.com>, <treding@nvidia.com>, <k.kozlowski@samsung.com>
Subject: Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings
References: <alpine.DEB.2.10.1601121226060.5214@hadrien>
In-Reply-To: <alpine.DEB.2.10.1601121226060.5214@hadrien>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To
 bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Julia,
Thanks for pointing this issue.

What script do you run to get this error?

I tried to run script/coccicheck and it did not showed this issue.

When I run make with coccicheck per Documentation, it did not show 
specific to this error. Although, there was lots of output.

I want to get this type of error by running script.
Any command for this?

Thanks,
Laxman



On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote:
> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>
> Generated by: scripts/coccinelle/misc/of_table.cocci
>
> CC: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
>   rtc-max77xxx.c |    1 +
>   1 file changed, 1 insertion(+)
>
> --- a/drivers/rtc/rtc-max77xxx.c
> +++ b/drivers/rtc/rtc-max77xxx.c
> @@ -480,6 +480,7 @@ static const struct platform_device_id m
>   	{ .name = "max77xxx-rtc", },
>   	{ .name = "max77620-rtc", },
>   	{ .name = "max20024-rtc", },
> +	{},
>   };
>
>   static struct platform_driver max77xxx_rtc_driver = {