Re: [PATCH] arm: dts: zynq: Add MicroZed board support

Michal Simek
2016-01-12T12:02:40Z

On 12.1.2016 11:49, Jagan Teki wrote:
> On Tuesday 12 January 2016 04:13 PM, Michal Simek wrote:
>> On 12.1.2016 06:53, Jagan Teki wrote:
>>> Added basic dts support for MicroZed board.
>>>
>>> Cc: Soren Brinkmann <soren.brinkmann@xilinx.com>
>>> Cc: Michal Simek <michal.simek@xilinx.com>
>>> Signed-off-by: Jagan Teki <jteki@openedev.com>
>>> ---
>>> arch/arm/boot/dts/Makefile | 1 +
>>> arch/arm/boot/dts/zynq-microzed.dts | 45
>>> +++++++++++++++++++++++++++++++++++++
>>> 2 files changed, 46 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/zynq-microzed.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index 30bbc37..9eb52fa 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -725,6 +725,7 @@ dtb-$(CONFIG_ARCH_VT8500) += \
>>> wm8750-apc8750.dtb \
>>> wm8850-w70v2.dtb
>>> dtb-$(CONFIG_ARCH_ZYNQ) += \
>>> + zynq-microzed.dtb \
>>> zynq-parallella.dtb \
>>> zynq-zc702.dtb \
>>> zynq-zc706.dtb \
>>> diff --git a/arch/arm/boot/dts/zynq-microzed.dts
>>> b/arch/arm/boot/dts/zynq-microzed.dts
>>> new file mode 100644
>>> index 0000000..a8c7d2b
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/zynq-microzed.dts
>>> @@ -0,0 +1,45 @@
>>> +/*
>>> + * Copyright (C) 2015 Jagan Teki <jteki@openedev.com>
>>> + *
>>> + * This software is licensed under the terms of the GNU General Public
>>> + * License version 2, as published by the Free Software Foundation, and
>>> + * may be copied, distributed, and modified under those terms.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +/dts-v1/;
>>> +/include/ "zynq-7000.dtsi"
>>> +
>>> +/ {
>>> + model = "Zynq MicroZED Development Board";
>>> + compatible = "xlnx,zynq-microzed", "xlnx,zynq-7000";
>>> +
>>> + aliases {
>>> + serial0 = &uart1;
>>> + };
>>> +
>>> + memory {
>>> + device_type = "memory";
>>> + reg = <0x0 0x40000000>;
>>> + };
>>> +
>>> + chosen {
>>> + bootargs = "earlyprintk";
>>> + stdout-path = "serial0:115200n8";
>>> + };
>>> +};
>>> +
>>> +&clkc {
>>> + ps-clk-frequency = <33333333>;
>>> +};
>>> +
>>> +&sdhci0 {
>>> + status = "okay";
>>> +};
>>> +
>>> +&uart1 {
>>> + status = "okay";
>>> +};
>>>
>>
>> I would prefer to have full description of this board instead of partial
>> one. In U-Boot there is also qspi enabled. Board has also USB and
>> ethernet that's why all of these should be enabled and tested.
>
> I have verified what all I added like uart, mmc ie why I described as
> basic support.
>
> May be we can move this first and rest will add in future like USB and
> Ethernet. For qspi the driver is not mainlined yet.

Adding USB, ethernet should be quite simple. It means if you have the
board please test it and send v2 with that.
Hopefully both 7010 and 7020 microzed boards are the same.

Thanks,
Michal