From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762332AbcALOQt (ORCPT ); Tue, 12 Jan 2016 09:16:49 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37243 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762047AbcALOQr (ORCPT ); Tue, 12 Jan 2016 09:16:47 -0500 Subject: Re: [RFC PATCH 2/2] sched: idle: IRQ based next prediction for idle period To: Thomas Gleixner References: <1452093774-17831-1-git-send-email-daniel.lezcano@linaro.org> <1452093774-17831-3-git-send-email-daniel.lezcano@linaro.org> <5694F490.3040300@linaro.org> Cc: peterz@infradead.org, rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, nicolas.pitre@linaro.org, vincent.guittot@linaro.org From: Daniel Lezcano Message-ID: <56950ACC.4090001@linaro.org> Date: Tue, 12 Jan 2016 15:16:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2016 02:42 PM, Thomas Gleixner wrote: > On Tue, 12 Jan 2016, Daniel Lezcano wrote: >> On 01/08/2016 04:43 PM, Thomas Gleixner wrote: >>>> + /* >>>> + * Register the setup/free irq callbacks, so new interrupt or >>>> + * freed interrupt will update their tracking. >>>> + */ >>>> + ret = register_irq_timings(&irqt_ops); >>>> + if (ret) { >>>> + pr_err("Failed to register timings ops\n"); >>>> + return ret; >>>> + } >>> >>> So that stuff is installed unconditionally. Is it used unconditionally as >>> well? >> >> Sorry, I am not sure to understand your question. If the kernel is compiled >> with CONFIG_CPU_IDLE_GOV_SCHED=y, this code is enabled and use the irq >> timings. The condition comes from the compilation option. > > The question is whether the option also activates that thing or is there still > some /sys/whatever/idlegov magic where you can (de)select it. Yes, in the next patches of the series I did not send, we can switch to the cpuidle's governor framework or idle-sched. I will look at how to disable it when switching to the cpuidle's governors. Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog