From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933058AbcALQPT (ORCPT ); Tue, 12 Jan 2016 11:15:19 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35723 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbcALQPP (ORCPT ); Tue, 12 Jan 2016 11:15:15 -0500 Subject: Re: [PATCH V2 11/23] arm64, pci: Remove useless boot time IRQ assignment when booting with DT. To: Lorenzo Pieralisi , matt@masarand.com References: <1450278993-12664-1-git-send-email-tn@semihalf.com> <1450278993-12664-12-git-send-email-tn@semihalf.com> <20160112135023.GC3601@red-moon> Cc: bhelgaas@google.com, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rjw@rjwysocki.net, hanjun.guo@linaro.org, okaya@codeaurora.org, jiang.liu@linux.intel.com, Stefano.Stabellini@eu.citrix.com, robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, tglx@linutronix.de, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jchandra@broadcom.com, jcm@redhat.com From: Tomasz Nowicki Message-ID: <56952619.7010602@semihalf.com> Date: Tue, 12 Jan 2016 17:13:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160112135023.GC3601@red-moon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.01.2016 14:50, Lorenzo Pieralisi wrote: > On Wed, Dec 16, 2015 at 04:16:21PM +0100, Tomasz Nowicki wrote: >> In order to probe PCIe host controller when booting with DT, >> ARM64 is using drivers which defer IRQ assignment to device >> enable time. It means that boot time DT specific irq map initialization >> is always overridden, so lets remove that code. >> >> Signed-off-by: Tomasz Nowicki >> --- >> arch/arm64/kernel/pci.c | 10 ---------- >> 1 file changed, 10 deletions(-) >> >> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c >> index 023b983..f7948f5 100644 >> --- a/arch/arm64/kernel/pci.c >> +++ b/arch/arm64/kernel/pci.c >> @@ -51,16 +51,6 @@ int pcibios_enable_device(struct pci_dev *dev, int mask) >> return pci_enable_resources(dev, mask); >> } >> >> -/* >> - * Try to assign the IRQ number from DT when adding a new device >> - */ >> -int pcibios_add_device(struct pci_dev *dev) >> -{ >> - dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); >> - >> - return 0; >> -} >> - > > Actually, this patch should be part of Matthew's series: > Agree. Matthew can you please add this patch to your series? Thanks, Tomasz