From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763944AbcALR4S (ORCPT ); Tue, 12 Jan 2016 12:56:18 -0500 Received: from mail-bn1on0073.outbound.protection.outlook.com ([157.56.110.73]:35648 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1763925AbcALR4N (ORCPT ); Tue, 12 Jan 2016 12:56:13 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <56953E33.6030003@caviumnetworks.com> Date: Tue, 12 Jan 2016 09:56:03 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tomasz Nowicki CC: Lorenzo Pieralisi , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH V2 11/23] arm64, pci: Remove useless boot time IRQ assignment when booting with DT. References: <1450278993-12664-1-git-send-email-tn@semihalf.com> <1450278993-12664-12-git-send-email-tn@semihalf.com> <20160112135023.GC3601@red-moon> <56952619.7010602@semihalf.com> In-Reply-To: <56952619.7010602@semihalf.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BN1PR07CA0072.namprd07.prod.outlook.com (10.255.193.47) To DM3PR07MB2137.namprd07.prod.outlook.com (25.164.4.143) X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;2:ulY8VeRIdou8e055k7VaytPTGjdU2IcSgdftiERg23s90hqnFdZbViRbe1J6C1k4ueZaA54gts1JqRTH00f0jjKJ9RRYQgDm58Q45uomYA0ZpaD6bgw1lToEgKlc62HxnFgtZyBxIvXfbT9JvRtOkA==;3:mR/aJjiCblewNiZ9hxG0UwYFtmBGc5NE0zw9Kl0I8EM5Hv4CmD3rtaRMugkpHHK2b4k0HQH8i4fF6HXyqjgR1wHXqS2RSg0CpXX03XD8N6yuTvEj0dO0XSz3V74WmiEs;25:b5kHbUSPmv9Lk8euhnpD2RzAJIUL/L85SJizYz8mcg+t3KzDDVBHo8eaUSZz2/4EEt49fesyCbVHboU7dlYihh72x/2+/rOngyswLpesMiT52ZgD5EnGWpTKzrbvXvkslr00vQZHCazdLF5/cX3pb/eNuTkbYWUaJhr+S/kAeAdaw+cM/+LRnZyVfrdyy2ztQQ/XHkEWiKtFr33AAfXsAci/vI4PwQJ4sYi+Y2EVx/5KMuHUn5z4HJ3dUKffpqLx X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2137; X-MS-Office365-Filtering-Correlation-Id: b297434d-13e9-4717-d6ad-08d31b79a76e X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;20:V/+e2yFKoNo1Nk7cN5tHVX7uGG/tW9mH2G6XariGShBovrJS932D5n+SyE+i0cwTbOuih+sHcPGVUu3vm25ZpMlM9ww7sFOIelwjk2mSHZdHoK/sbQi879v9hxnpvJs7zG0xcRYbzUUzcX/qic7I9Vc5/lCbYb4gDNmxn5rIF7YRLjfmeeorD1/SZhhxhOtyvA2aGZiBuynES/fIXSUfva/bNYN593ExiuGwEAZF89gpOJsg98+AoR/jJmAsCVfjRlztenpn53FLM9jtp/GY9SP32a5y6mkPTbtkWlwuOtFR0m/HdrSWrqzSrkQ75rBHvg8P1TjxPfELA5aV9i+H3JOtnUxl5yGupZOQbLrE3nM9b3HDDOF487vYi9ML0WTDA2rCsFV/kDIB7b/zfA663VOey+2474j1un7OB90X8+Q1uQxfWrUSEiuU1wXyX+GEeWCdKog90X+Zqwx6TgnnVDE8bT+3nOem4BKos9/Ma0JE3x/tVJS4vE9gaAKb0YkH2o8Hxex8vuWohI9Vgk/WR4aK74NsKo5YZmhf5rqTPQyw2VL7k/AsZVYlLu2FNdFbx7kVfYJB/9X0r68i3+xc1QkqOmWMPr2glGFPd2DIgHI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046);SRVR:DM3PR07MB2137;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2137; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;4:qyAWDEYJDUwZpMGxXzqINnDauc9jDQwu2FEMjWpTpOcwDjQFotvlekzgJok6B4BCV9ZPpkaL6ojopeg2VqlNHC42CQNRPriXSgZwXzYLwmOpGngJMrfpKKVvQRZiR2vJUtMnU8SOomLXrTBGoa7EMMCIGPl1dDXQffm4lrjMGhFB+jIfIQWM/VJAVYO7WuOHmiLESGVeKE3tELg1vlMzJnY1MhHKaiYxQF7NTAA97nfYYW/5+jzRx0B0udLxyuuGRtL8TuQ3oIFkyXpQQ/a7jEC31pyNnIwUXl0TOBS6QNX8BLl4kHoeeWIpO6I074M2CK5bKHvcFV3sXA+vQ51WFoBo/5HKO31+mk71G5vBGsvkd2wnPMhMIkduE6df/6nE X-Forefront-PRVS: 081904387B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(24454002)(164054003)(189002)(479174004)(199003)(42186005)(53416004)(189998001)(87266999)(4001350100001)(87976001)(36756003)(81156007)(106356001)(76176999)(65956001)(101416001)(50986999)(66066001)(65806001)(54356999)(65816999)(97736004)(4326007)(5001960100002)(5008740100001)(110136002)(99136001)(23746002)(2906002)(33656002)(230700001)(105586002)(92566002)(50466002)(59896002)(6116002)(80316001)(83506001)(19580395003)(93886004)(19580405001)(3846002)(1096002)(586003)(69596002)(47776003)(64126003)(77096005)(40100003)(5004730100002)(122386002)(2950100001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2137;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM3PR07MB2137;23:mM05ksVNT1nMMMT8UXRFm1kYd3n0YQyxj/L0p?= =?Windows-1252?Q?wW5Mh6KEA0b48rn3lGbvpzxoZ0bpeqbv0F29jjxfNsoa9OmQ80AO36cw?= =?Windows-1252?Q?QK23hBsGFHQ85tCNHeBmjx3/0SSrQcJP4OKQRVSZSIXWV1vqJxNEHc+O?= =?Windows-1252?Q?85kmzlGbfP5stgr2y2yP5TC0Hz9zvZ8nLR7l6xzjTxYhB3pEjxU5tfG+?= =?Windows-1252?Q?ArwD3F34h+cW4KY0pArSDffRG/unVfPVSSb0/EfomtIeIIn6W0hvGpXc?= =?Windows-1252?Q?kTy/SMbbGOSdglfOuHdRvXT2JHiC86/EUEc82+CU4iTZs6LLSL1f9kSE?= =?Windows-1252?Q?T0Z8qJ8muThGUw8z8/Smpt34R9fKtEsINHjyQf4XggzHKD0BmjLmZDvR?= =?Windows-1252?Q?XszoCC7Tbf/Xg8RPr6Xtzxc28lYwgmUQ1ihBMcaWoDRItuGVXb/lJjv4?= =?Windows-1252?Q?lHMV8sk2/P6kzeWZOGh8LD7dSbOVW/75bPVZAb38qgpMmtOKGR/iHoBF?= =?Windows-1252?Q?QXuw7EcfRF0ICLY/+TWlnv45i/GNyECGiPdAxX4OAsaUdI26KOnKGFxX?= =?Windows-1252?Q?ZYdu7+hvY6lUHQP6Btoffm2AAylh8Pr6VW4D2Q8lrQztNzjGwYBAd+4U?= =?Windows-1252?Q?kJeRXbw+8MQFPJkZuExzf/mO3rrxiFumow7Ety+1usyfsXhlpOv2LCbX?= =?Windows-1252?Q?0YDoIMgiu6qYQ4nNh1SoqUcIRLuRAPSstmDJkio+sqLly8ADC2696Tm+?= =?Windows-1252?Q?tyPDJuf5H9aYJZiIUE/Qe1gflwt82jYQYs9WQh2cpQp96kD4s8ynSmtZ?= =?Windows-1252?Q?JlH5r8pCS+uQZtdeMRHCG2g1SV6StecdjVYZR7XBZ+Aqbmiz/+wgVOPK?= =?Windows-1252?Q?55wxVXBH+Bfx1uKWyvIhIN88EhpGtBHgw4lJWyQgLj6laPBVzQmJoi82?= =?Windows-1252?Q?XDAlmoIRWUCck2qB8qZ5WODuh1N/v++8AbwBfAFZFMA0NS6drFjDsaLY?= =?Windows-1252?Q?oO5jUnLFSJVq2LXFjldLnVAuZyoBirk+nRBnRcIIdfh6pHUCdGlOwYXL?= =?Windows-1252?Q?S06fXYWBWRHCM6Ry8xFzXujTP/qhI5QypqOUgcotoAGIRrAs6JN1637y?= =?Windows-1252?Q?nrg5D+BnbebE9lLT7z0/Krapb/qvqZd/zrQ0EPf2vOZ0tKp2vFrJnmYS?= =?Windows-1252?Q?isQ8mTfgkuNEZ5fE1Pyd1h9uphmz7q5dG9JxJbS6TZ8T5tCnaQef/z92?= =?Windows-1252?Q?d2NaraXb8CMYweMgURpoeNo6cgzCOhnNLrrCMj1XFPLvNolwld42jmMa?= =?Windows-1252?Q?TzLyi8Mms/298+qBaWaEJmUl36GvSAh0eQjoLDb5ue0r5MiUUGn947NV?= =?Windows-1252?Q?JYuztcByR6ZUNpZmPJPRleLbWXcsa9H9LhKZJNzQ338ZzxXIUpg4u810?= =?Windows-1252?Q?I3xwXguakW6HFTckF0KGevWuG3DjwJsmtEl4f1gJQfwseOfT5EFVQ6Wd?= =?Windows-1252?Q?MetWCGsUHTScKCxzI2WOD+SSPC5?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;5:260YpIlpUGvukMrJJpK4pR8I30XMs1vRTI5GU2LmLSmNsI/x7E6fKwJqcWpDRJFmuGrPttwvAEPQvGvqSAx7rIluTU6wYIzYKdjdzLU4+CmwCVo828QYxnB/HZj80mf+Kg9OiAI32wTDiarIr2RZ2w==;24:4R01KVxJZvL1mj9CGslaRosPaDVcOvhcBLzdqG0361M++6ZlBBz3hMqVmjcM7HeCFNtMMmus1/kwsIDvsBG26RuamNqgxhFjL77rcK5RC8A= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2016 17:56:07.2483 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2137 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2016 08:13 AM, Tomasz Nowicki wrote: > On 12.01.2016 14:50, Lorenzo Pieralisi wrote: >> On Wed, Dec 16, 2015 at 04:16:21PM +0100, Tomasz Nowicki wrote: >>> In order to probe PCIe host controller when booting with DT, >>> ARM64 is using drivers which defer IRQ assignment to device >>> enable time. It means that boot time DT specific irq map initialization >>> is always overridden, so lets remove that code. >>> >>> Signed-off-by: Tomasz Nowicki >>> --- >>> arch/arm64/kernel/pci.c | 10 ---------- >>> 1 file changed, 10 deletions(-) >>> >>> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c >>> index 023b983..f7948f5 100644 >>> --- a/arch/arm64/kernel/pci.c >>> +++ b/arch/arm64/kernel/pci.c >>> @@ -51,16 +51,6 @@ int pcibios_enable_device(struct pci_dev *dev, int >>> mask) >>> return pci_enable_resources(dev, mask); >>> } >>> >>> -/* >>> - * Try to assign the IRQ number from DT when adding a new device >>> - */ >>> -int pcibios_add_device(struct pci_dev *dev) >>> -{ >>> - dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); >>> - >>> - return 0; >>> -} >>> - How was this tested? Or in other words, what PCI devices that use legacy INT{A,B,C,D} interrupts were used in testing this patch? David Daney >> >> Actually, this patch should be part of Matthew's series: >> > > Agree. > > Matthew can you please add this patch to your series? > > Thanks, > Tomasz