From: Helge Deller <deller@gmx.de>
To: Michael Ellerman <mpe@ellerman.id.au>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Parisc List <linux-parisc@vger.kernel.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: strange commit in the parisc-hd tree
Date: Tue, 12 Jan 2016 22:43:54 +0100 [thread overview]
Message-ID: <5695739A.9050700@gmx.de> (raw)
In-Reply-To: <1452551991.23317.3.camel@ellerman.id.au>
On 11.01.2016 23:39, Michael Ellerman wrote:
> On Mon, 2016-01-11 at 22:46 +0100, Helge Deller wrote:
>> On 10.01.2016 23:28, Stephen Rothwell wrote:
>>> I noticed the following commit in the parisc-hd tree today:
>>>
>>> 43122681dd75 ("Fix __ARCH_SI_PREAMBLE_SIZE on parisc")
>>>
>>> which among other things says:
>>>
>>> This patch is not planned to be committed as it currently is.
>>
>> Right, I split it up into two.
>>
>>> [...] Please remove it from linux-next inclusion until it is ready.
>>
>> Sure, I just removed it now.
>>
>>> Delibeately introducing a patch to linux-next that may well cause build breakage
>>> in other architectures just before the merge window opens is a bit antisocial.
>>
>> That was in no way my intention.
>> In contrary, I wanted to see if other platforms are affected by the same bug without knowing.
>> Do you by any chance know if it broke some of the existing platforms?
>> If yes, that would be valuable info...
>>
>> Just in case people want to know what this is all about:
>> On parisc I found __ARCH_SI_PREAMBLE_SIZE to have a wrong value in 64bit kernel builds.
>> Patch which fixes it is here:
>> https://patchwork.kernel.org/patch/7994821/
>>
>> To prevent other (existing and future) architectures to run into the same
>> problem I wanted to test this patch via linux-next and inform them:
>> http://git.kernel.org/cgit/linux/kernel/git/deller/parisc-linux.git/commit/?h=test__ARCH_SI_PREAMBLE_SIZE
>
> That doesn't fire on powerpc, ie. we have it correct.
It really seems that parisc was the only architecture left which had a wrong value for __ARCH_SI_PREAMBLE_SIZE.
I followed Stephens suggestion to try it via the zero day build farm and it was only reported one problem (for parisc).
Tree is here: http://git.kernel.org/cgit/linux/kernel/git/deller/parisc-linux.git/log/?h=for-next-test
> Though I wonder why it's not just defined using offsetof? Possibly just that
> it's awkward with the way the headers are organised.
Yes.
Helge
prev parent reply other threads:[~2016-01-12 21:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 22:28 linux-next: strange commit in the parisc-hd tree Stephen Rothwell
2016-01-11 21:46 ` Helge Deller
2016-01-11 22:32 ` Stephen Rothwell
2016-01-11 22:39 ` Michael Ellerman
2016-01-12 21:43 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5695739A.9050700@gmx.de \
--to=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox