From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754006AbcALXzi (ORCPT ); Tue, 12 Jan 2016 18:55:38 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:57905 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbcALXzh (ORCPT ); Tue, 12 Jan 2016 18:55:37 -0500 X-AuditID: cbfec7f5-f79b16d000005389-3d-56959276edaa Subject: Re: [PATCH v3] arm: irq: l2c: do not print error in case of missing l2c from dtb To: Andi Shyti , linux-arm-kernel@lists.infradead.org References: <5694BABF.3070200@samsung.com> <1452593472-10703-1-git-send-email-andi.shyti@samsung.com> Cc: linux@arm.linux.org.uk, tony@atomide.com, robh@kernel.org, tglx@linutronix.de, olof@lixom.net, tomasz.figa@gmail.com, jiang.liu@linux.intel.com, yamada.masahiro@socionext.com, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, andi@etezian.org From: Krzysztof Kozlowski Message-id: <56959275.80404@samsung.com> Date: Wed, 13 Jan 2016 08:55:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1452593472-10703-1-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsVy+t/xa7plk6aGGVyfrmix/cgzVovFP54z Wczavp/F4vULQ4tNj6+xWlzeNYfN4vZlXou1R+6yW5y6/pnN4v+eHewWmzdNZbZYtesPo8X+ K14We+99ZnTg82hp7mHz+PZ1EovH9SWfmD12zrrL7rFpVSebx7tz59g95p0M9Ni8pN7jyokm Vo++LasYPU5M/87i8XmTXABPFJdNSmpOZllqkb5dAlfGnZ6jLAXvOSvmLt7B3MD4nL2LkZND QsBEYs3EZcwQtpjEhXvr2boYuTiEBJYySuxYsYcVwnnKKPF6zQGwKmGBaIlbTxczgtgiAr4S C/a+YOli5AAqSpd4exKshFmgiUliwoVKEJtNwFhi8/IlbCA2r4CGxKVZ/WCLWQRUJU6CxTk4 RAUiJBbtyIQoEZT4MfkeC4jNKeAucagZpJwDaKSexP2LWhDT5SU2r3nLPIFRYBaSjlkIVbOQ VC1gZF7FKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERJhX3cwLj1mdYhRgINRiYc3g31KmBBr YllxZe4hRgkOZiUR3vVVU8OEeFMSK6tSi/Lji0pzUosPMUpzsCiJ887c9T4E6PPEktTs1NSC 1CKYLBMHp1QDo+ly3c8MVa8566OuRwamTJyw8OO3OhuOPZ+2R4TIi+1nUTrl+KNs2SG2/cUT p/5herLoSMfB+GtbP7NLrd9Y1ZY2c65Hc7XoahEX2f513zgmLauc+4ozpThcfbKY8Jv9qxJU WHslt4aWzUs4WJvTzPBOz+3I00y/2Tx8UWx7M5f83dfXwl2qpsRSnJFoqMVcVJwIABNbRNGs AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.01.2016 19:11, Andi Shyti wrote: > In some architectures the L2 cache controller is integrated in the > processor's block itself and it doesn't use any external cache > controller. This means that an entry in the board's dtb related > to the l2c is not necessary. > > Distinguish between error codes and do not print anything in case > l2x0_of_init() doesn't find any L2C DTB entry and returns -ENODEV. > > This patch mutes the following error message: > > L2C: failed to init: -19 > > on boards like odroid-xu4, cortex A7/A15, which don't have > external cache controller. > > Signed-off-by: Andi Shyti > Reported-by: Krzysztof Kozlowski > Reviewed-by: Krzysztof Kozlowski > --- > Hi, > > here is a second version. An alternative would be to print with > pr_dbg, but then it's a matter of taste. > > V1, and V2 print a message in case the l2c dtb entry is not found > (the V2 has a better print rephrase suggested by Joe) > > V3 ignores the case of -enodev for l2c and doesn't print anything > > Thanks, > Andi Looks good to me, as v2 did. Works fine: Tested-by: Krzysztof Kozlowski BR, KRzysztof