From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754029AbcAMAGS (ORCPT ); Tue, 12 Jan 2016 19:06:18 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:14754 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbcAMAGP (ORCPT ); Tue, 12 Jan 2016 19:06:15 -0500 X-AuditID: cbfec7f4-f79026d00000418a-d7-569594f3e442 Subject: Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx series RTC IP To: Laxman Dewangan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-6-git-send-email-ldewangan@nvidia.com> Cc: lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com From: Krzysztof Kozlowski Message-id: <569594F0.4020007@samsung.com> Date: Wed, 13 Jan 2016 09:06:08 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1452590273-16421-6-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t/xq7qfp0wNM3i8RMNiycWr7BYd1xYz WUx9+ITNYv6Rc6wW/W8Wslqce/WIBUisZLR4/cLQYum+1SwW978eZbT4dqWDyWLKn+VMFpvn /2G0uLxrDpvF0usXmSwmTF/LYtG69wi7xf7ODkaLG9NbWC1u/+ZzEPFYM28No8flvl4mjyeb LjJ67Jx1l91jz8STbB4rl39h89i0qpPN4861PWwevc3v2Dz6tqxi9Jg+7yeTx+dNcgE8UVw2 Kak5mWWpRfp2CVwZF2b+YC+YzV+xbuYR5gbG39xdjJwcEgImElMun2GHsMUkLtxbz9bFyMUh JLCUUeLoqX2sEM5TRokTM9+wgVQJC8RIvFg9lwUkISKwnUli041njF2MHEBV9RIbWlRB4swC Wxklvm/9yALSwCZgLLF5+RKwZl4BLYmGeyfA1rEIqEr8OX2HDaRXVCBCYtGOTIgSQYkfk++B tXIKuEosOTyTBaSEWUBP4v5FLZAws4C8xOY1b5knMArMQtIxC6FqFpKqBYzMqxhFU0uTC4qT 0nMN9YoTc4tL89L1kvNzNzFC4vTLDsbFx6wOMQpwMCrx8GawTwkTYk0sK67MPcQowcGsJMK7 vmpqmBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHeubvehwgJpCeWpGanphakFsFkmTg4pRoYN/be LNoxYUWfc4hOzfxfv11zny9ef+6kZF73zzeHnsRksSTP+BQePm3CVeWEm75x+5+9iYn7zyjC +q379cUTF9Oefvo0IbTjxQmuD75L3MJ5ffuT6kXaHvBP445T/etooVX8Y86VKZkTT5eIb565 6P/cy/Z8BqdVDr3MqT1i+/rSDmmN7m1XBZVYijMSDbWYi4oTARYhq8vPAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.01.2016 18:17, Laxman Dewangan wrote: > Maxim Semiconductor's PMIC MAX77620, MAX77686, MAX20024 have > same RTC IP on these PMICs. > > Add generic MAX77xxxx series RTC driver which can be used as > RTC driver for these PMIC and avoids duplication of RTC driver > for each PMICs. Their MFD driver can be different here. > > Signed-off-by: Laxman Dewangan > --- > Changes from V1: > - Rename the file to rtc-max77xxx.c and make the generic implementation. > - Direct regmap apis are used for the register access. > - Decouped from max77620 driver. > - Taken care of cleanup comments form V1 version. > > drivers/rtc/Kconfig | 10 + > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-max77xxx.c | 500 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 511 insertions(+) > create mode 100644 drivers/rtc/rtc-max77xxx.c > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 376322f..4972dd5 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -315,6 +315,16 @@ config RTC_DRV_MAX8997 > This driver can also be built as a module. If so, the module > will be called rtc-max8997. > > +config RTC_DRV_MAX77XXX > + tristate "Maxim MAX77XXX series generic RTC driver" > + help > + If you say yes here you will get support for the generic RTC driver > + for Maxim Semiconductor MAX77XXX series of PMIC like MAX77620. > + This also supports the RTC driver for Maxim PMIC MaX20024 which > + is almost same as MAX77620. > + This driver can also be built as a module. If so, the module > + will be called rtc-max77xxx. > + That was not the consensus... You still added a new driver - but now with different name. That is useless duplication Please work with existing code. Use existing maxim RTC drivers: either max77686 or max77802. There is no need for new one. Best regards, Krzysztof