From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932307AbcAMJLA (ORCPT ); Wed, 13 Jan 2016 04:11:00 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:6540 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753718AbcAMJKr (ORCPT ); Wed, 13 Jan 2016 04:10:47 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 13 Jan 2016 01:06:17 -0800 Message-ID: <5696122A.6000509@nvidia.com> Date: Wed, 13 Jan 2016 14:30:26 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , , , , , , , , , , , CC: , , , , , , , Chaitanya Bandi , Mallikarjun Kasoju Subject: Re: [PATCH V2 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-3-git-send-email-ldewangan@nvidia.com> <56959E9A.3060903@samsung.com> In-Reply-To: <56959E9A.3060903@samsung.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 13 January 2016 06:17 AM, Krzysztof Kozlowski wrote: > On 12.01.2016 18:17, Laxman Dewangan wrote: >> + } >> + dev_dbg(chip->dev, "NVERC = 0x%02x\n", val); >> + for (i = 0; i < 8; ++i) { >> + if (val & BIT(i)) >> + dev_info(chip->dev, "NVERC: %s\n", max77620_nverc[i]); > You are still printing two dev_info (OTP, ES) and here NVERC (probably > one?). This will be printed on each boot, over and over, till the user > will learn it and will remember it forever :). > > From my point of view: one dev_info for one probed device. > > I don't know if others agree with that, though. What's your opinion Lee? OK, I make single line print for OTP and ES version. I remove the NVREC reading and printing as this is read on clear and better to move on uboot for this prints. > > > + > + ret = regmap_add_irq_chip(chip->rmap[MAX77620_PWR_SLAVE], > + chip->chip_irq, IRQF_ONESHOT | IRQF_SHARED, chip->irq_base, > Why do you need IRQF_SHARED? In one of my design, I have three PMICs, one MAX77620, two MAX77621. MAX77621 alert an MAX77620 interrupt line is tied and going to single interrupt of SoC. To register same interrupt from all driver, I made it SHARED. This is per discussion on the other patch regulator: max8973: add support for junction thermal warning >> + &max77620_top_irq_chip, &chip->top_irq_data); > More tabs needed for indentation of arguments. > > Actually the alignment of arguments here is mixed. Sometimes arguments > are aligned with opening parenthesis, mostly not. Can you make it > consistent - always aligned? In my 3rd patch, I tried to align it little more where is possible. But I feel that all these indenting is more over individual choice. Example, I added one more indent in below example to look better. ret = max77620_reg_update(chip->dev, MAX77620_PWR_SLAVE, - MAX77620_REG_ONOFFCNFG2, MAX77620_ONOFFCNFG2_WK_EN0, - MAX77620_ONOFFCNFG2_WK_EN0); + MAX77620_REG_ONOFFCNFG2, MAX77620_ONOFFCNFG2_WK_EN0, + MAX77620_ONOFFCNFG2_WK_EN0);