linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: Guenter Roeck <linux@roeck-us.net>, <lm-sensors@lm-sensors.org>
Cc: <jdelvare@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] hwmon: Add LTC2990 sensor driver
Date: Wed, 13 Jan 2016 15:03:41 +0100	[thread overview]
Message-ID: <5696593D.8030908@topic.nl> (raw)
In-Reply-To: <569657C8.6070607@roeck-us.net>

On 13-01-16 14:57, Guenter Roeck wrote:
> On 01/13/2016 05:51 AM, Mike Looijmans wrote:
>> On 13-01-16 14:24, Guenter Roeck wrote:
>>> On 01/13/2016 03:05 AM, Mike Looijmans wrote:
>>>> This adds support for the Linear Technology LTC2990  I2C System Monitor.
>>>> The LTC2990 supports a combination of voltage, current and temperature
>>>> monitoring. This driver currently only supports reading two currents
>>>> by measuring two differential voltages across series resistors, in
>>>> addition to the Vcc supply voltage and internal temperature.
>>>>
>>>> This is sufficient to support the Topic Miami SOM which uses this chip
>>>> to monitor the currents flowing into the FPGA and the CPU parts.
>>>>
>>>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>>>
>>> Mike,
>>>
>>> That looks much better. Can you send me the output of i2cdump for the chip ?
>>> That would help me writing module test code for it.
>>
>> I'm kinda interested into how that would work.
>>
> https://github.com/groeck/module-tests
>
>> I'll have to remove the driver first to get i2cdump to work on the chip. I
>> cannot force a device removal from user space while running, can I?
>> And i suppose you want a dump of a chip in running status? (On boot, all are
>> registers are simply set to zero)
>>
>
> Just use i2cdump -f while the driver is active.

Here's the dump (twice so you can see the A/D converter is actually running):

root@topic-miami-florida-pci-xc7z015:~# i2cdump -y -f -r 0-0xf 1 0x4c b
      0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 7f 1e 7f 7f 82 5f 80 44 80 44 80 3f 80 3f 89 b5    ?????_?D?D??????
root@topic-miami-florida-pci-xc7z015:~# i2cdump -y -f -r 0-0xf 1 0x4c b
      0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 7f 1e 7f 7f 82 65 80 42 80 42 80 3d 80 3d 89 b4    ?????e?B?B?=?=??




Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

  reply	other threads:[~2016-01-13 14:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06  8:07 [PATCH] hwmon: Add LTC2990 sensor driver Mike Looijmans
2016-01-06 15:22 ` Guenter Roeck
2016-01-07 18:59   ` Mike Looijmans
2016-01-08 15:09     ` Guenter Roeck
2016-01-13 11:22       ` Mike Looijmans
2016-01-13 11:05 ` [PATCH v2] " Mike Looijmans
2016-01-13 13:24   ` Guenter Roeck
2016-01-13 13:51     ` Mike Looijmans
2016-01-13 13:57       ` Guenter Roeck
2016-01-13 14:03         ` Mike Looijmans [this message]
2016-01-13 14:45   ` [PATCH v3] " Mike Looijmans
2016-01-14 19:14     ` Guenter Roeck
2016-01-15  9:54       ` Mike Looijmans
2016-01-15  9:54     ` [PATCH v4] " Mike Looijmans
2016-01-15 15:40       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5696593D.8030908@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=jdelvare@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).