From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752614AbcAMSLv (ORCPT ); Wed, 13 Jan 2016 13:11:51 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34713 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbcAMSLt (ORCPT ); Wed, 13 Jan 2016 13:11:49 -0500 Subject: Re: [PATCH v5 3/7] x86: mm/gup: add gup trace points To: akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com References: <1449696151-4195-1-git-send-email-yang.shi@linaro.org> <1449696151-4195-4-git-send-email-yang.shi@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org, Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org From: "Shi, Yang" Message-ID: <56969363.9010007@linaro.org> Date: Wed, 13 Jan 2016 10:11:47 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1449696151-4195-4-git-send-email-yang.shi@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi folks, Any comment for this one? The tracing part review has been done. Thanks, Yang On 12/9/2015 1:22 PM, Yang Shi wrote: > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Signed-off-by: Yang Shi > --- > arch/x86/mm/gup.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/x86/mm/gup.c b/arch/x86/mm/gup.c > index ae9a37b..df5f3ab 100644 > --- a/arch/x86/mm/gup.c > +++ b/arch/x86/mm/gup.c > @@ -12,6 +12,8 @@ > > #include > > +#include > + > static inline pte_t gup_get_pte(pte_t *ptep) > { > #ifndef CONFIG_X86_PAE > @@ -270,6 +272,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write, > (void __user *)start, len))) > return 0; > > + trace_gup_get_user_pages_fast(start, nr_pages); > + > /* > * XXX: batch / limit 'nr', to avoid large irq off latency > * needs some instrumenting to determine the common sizes used by > @@ -373,6 +377,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, > } while (pgdp++, addr = next, addr != end); > local_irq_enable(); > > + trace_gup_get_user_pages_fast(start, nr_pages); > + > VM_BUG_ON(nr != (end - start) >> PAGE_SHIFT); > return nr; > >