From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbcAMSM2 (ORCPT ); Wed, 13 Jan 2016 13:12:28 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34976 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbcAMSM1 (ORCPT ); Wed, 13 Jan 2016 13:12:27 -0500 Subject: Re: [PATCH v5 5/7] s390: mm/gup: add gup trace points To: akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com References: <1449696151-4195-1-git-send-email-yang.shi@linaro.org> <1449696151-4195-6-git-send-email-yang.shi@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org, Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org From: "Shi, Yang" Message-ID: <56969389.9060703@linaro.org> Date: Wed, 13 Jan 2016 10:12:25 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1449696151-4195-6-git-send-email-yang.shi@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi folks, Any comment for this one? The tracing part review has been done. Thanks, Yang On 12/9/2015 1:22 PM, Yang Shi wrote: > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s390@vger.kernel.org > Signed-off-by: Yang Shi > --- > arch/s390/mm/gup.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/s390/mm/gup.c b/arch/s390/mm/gup.c > index 12bbf0e..a1d5db7 100644 > --- a/arch/s390/mm/gup.c > +++ b/arch/s390/mm/gup.c > @@ -12,6 +12,8 @@ > #include > #include > > +#include > + > /* > * The performance critical leaf functions are made noinline otherwise gcc > * inlines everything into a single function which results in too much > @@ -188,6 +190,9 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write, > end = start + len; > if ((end <= start) || (end > TASK_SIZE)) > return 0; > + > + trace_gup_get_user_pages_fast(start, nr_pages); > + > /* > * local_irq_save() doesn't prevent pagetable teardown, but does > * prevent the pagetables from being freed on s390. >