From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754237AbcAMSNM (ORCPT ); Wed, 13 Jan 2016 13:13:12 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34322 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753958AbcAMSNK (ORCPT ); Wed, 13 Jan 2016 13:13:10 -0500 Subject: Re: [PATCH v5 7/7] sparc64: mm/gup: add gup trace points To: akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com References: <1449696151-4195-1-git-send-email-yang.shi@linaro.org> <1449696151-4195-8-git-send-email-yang.shi@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org, "David S. Miller" , sparclinux@vger.kernel.org From: "Shi, Yang" Message-ID: <569693B4.6060305@linaro.org> Date: Wed, 13 Jan 2016 10:13:08 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1449696151-4195-8-git-send-email-yang.shi@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Any comment on this one? The tracing part review has been done. Thanks, Yang On 12/9/2015 1:22 PM, Yang Shi wrote: > Cc: "David S. Miller" > Cc: sparclinux@vger.kernel.org > Signed-off-by: Yang Shi > --- > arch/sparc/mm/gup.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c > index 2e5c4fc..5a06c34 100644 > --- a/arch/sparc/mm/gup.c > +++ b/arch/sparc/mm/gup.c > @@ -12,6 +12,8 @@ > #include > #include > > +#include > + > /* > * The performance critical leaf functions are made noinline otherwise gcc > * inlines everything into a single function which results in too much > @@ -174,6 +176,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write, > len = (unsigned long) nr_pages << PAGE_SHIFT; > end = start + len; > > + trace_gup_get_user_pages_fast(start, nr_pages); > + > local_irq_save(flags); > pgdp = pgd_offset(mm, addr); > do { > @@ -236,6 +240,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, > > local_irq_enable(); > > + trace_gup_get_user_pages_fast(start, nr_pages); > + > VM_BUG_ON(nr != (end - start) >> PAGE_SHIFT); > return nr; > >