From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753623AbcAMVVN (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jan 2016 16:21:13 -0500
Received: from mout.web.de ([212.227.17.12]:52365 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753380AbcAMVVK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jan 2016 16:21:10 -0500
To: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        "David S. Miller" <davem@davemloft.net>,
        Igal Liberman <igal.liberman@freescale.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Subject: fsl/fman: Clarification for implementation details in dtsec_config()
X-Enigmail-Draft-Status: N1110
Message-ID: <5696BFAD.9030905@users.sourceforge.net>
Date: Wed, 13 Jan 2016 22:20:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:mBP1MfvMo33g0P5H4ZGhlOvOgo70ykd8jeOZQozn+5eNZKnmfTO
 MHrad1IJFr/VxwOpi6oU883KxzVmb3lkT/Fqe9mF7MnZt90282b4+4G+0GbnXpoFGCepnPI
 7zgUCdajrhWqZqauNBhFAITwWqEzElsP8Kx07dQrSJPJpTtLMSa3NDU6D0l0PQpSNVeU3Su
 RfhN5XtJ9dHw7bIBOYoeQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:mzeeYM7KOZ8=:frxDkUe2mEM63vqDV5/+Wj
 zoaMnHUlPoyTmfTBK7uq6m00FdXxEkrwnKPY8wQUk2siipiQQg+qO8MLTxHkpPxKmVL1+XRW7
 WUiJyheXezI0CsSH2MuDdOsgseIYF6C2KRRkQ2S5QS6lltkV3iM8znLhF+XwHGKmX9zwXdWGm
 fzLUCnURBEv5fLPxwagNFKroK4bNlrCUsDq2n0l3mHRH2Y+jn8kNU/AxcUmjRYiydfUnhcJ1Q
 vKfbnEgBVTMEOVt4nL62PzlcPilKr84JIVMOZnjtg0TnZrQzFoqUpa6PFGyItKoyLV7KFoNeg
 dX4wBcfnRYCQtAfX1YBMu4+eYe4Zsuw8YU+EaDZrVm0kMf5O/kzNMUR6i+qZS0HfJI3DitwaV
 SlrhOSM22/b7OpKF/h1Z4Wb1WWrOmNzOKTG/oSJSqBiqzIJzVbFfTIzhNQwrHdaSjk0NtqLrK
 htSgu7D3HHpemBOp3AngcqldhkYzkN2TdzNU1zJaIqYS4qwyvBhT6XSFv4Jrd+BpnLxw4G2cc
 qCXMoGotn5Dx/TaJEI7G6w0YOMHLBXZUP0rnHlThwRvA5lsxgpw0otWrpA/urjkvMPwAinaPR
 j8r6tQgV6ZUA/2ZPlK+82Sm6kQpnsvkbP6sihOVIC1fnuI5AyfrXA1mzuS1W8aOEE5BoYYSxN
 7IXNU3cNqLT1hYZScMaFDz4tP9krdY2xp7YkpqkfJUe5DDu2lZi2nszW4v1Y6PR6oXQne/g9+
 Rs5wKRN+sfL0j7PIwfeKbkmvftfAedtna+lgCyYBSCchVLxZLygWex2ikD3sAitX9YIP4uguh
 VmvmcnZ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

The Coccinelle semantic patch "deref_null.cocci" pointed out a potential
problem in the implementation of the function "dtsec_config" (lines 1434-1439):
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/freescale/fman/fman_dtsec.c?id=e5a03bfd873c29eb786655ef2e95e53ed242b404#n1434
…
	dtsec->tbiphy = of_phy_find_device(params->internal_phy_node);
	if (!dtsec->tbiphy) {
		pr_err("of_phy_find_device (TBI PHY) failed\n");
		put_device(&dtsec->tbiphy->mdio.dev);
		goto err_dtsec_drv_param;
	}
…

If the pointer "dtsec->tbiphy" is NULL, then it will especially matter
if the shown address computation will succeed.
Should the call of the function "put_device" be removed,
or was another argument intended?

Regards,
Markus