From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093AbcAMWqy (ORCPT ); Wed, 13 Jan 2016 17:46:54 -0500 Received: from mail-by2on0061.outbound.protection.outlook.com ([207.46.100.61]:3140 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750744AbcAMWqv (ORCPT ); Wed, 13 Jan 2016 17:46:51 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v4] i2c: designware: Do not require clock when SSCN and FFCN are provided To: Wolfram Sang References: <1451920655-10798-1-git-send-email-Suravee.Suthikulpanit@amd.com> <20160110083812.GE1526@katana> CC: , , , , , , , , "Hurwitz, Sherry" , Tom Lendacky From: Suravee Suthikulanit Message-ID: <5696D3D1.2010509@amd.com> Date: Wed, 13 Jan 2016 16:46:41 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160110083812.GE1526@katana> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BY2PR06CA062.namprd06.prod.outlook.com (10.141.250.180) To BLUPR12MB0436.namprd12.prod.outlook.com (25.162.92.141) X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;2:ae+ucyD+y1SpXc/6r+ZTEmMbcv0UW356uvu1DFz742Bs9q58YFrCuKN5BE1WFre+TLGev8DECAc2SO3x84kAv8HiMZdg5p2yNhBf+Ben5sO9EvMRajkbq720IdeioD0j/3xoLmJXzJZyhVSmZO3iJA==;3:q0bAKIJwVFh0gS8qdmJCmCheDApnbuMxhv9yjSBtt1RXco6oGGVE2x5KCxyB0+1ye4grhBGe7xTzUtSRIwZy8ERGm500NdP1MGBIjN6hBUtbFbK7FGiyX30klBulPHLO;25:G1sYDxoCyexFBVcxsMo/zpO928C6uG/8ldqoAbBs5UrPHvggtGwWshuYbFJUUM78bPt88aMOSa7lvRWuLzEMLpRjCx0Na4RQyumv+oBOUSpjtsyx0sSwrQCN5gfH8E7kULOBsXqm4CPrncDrcf4PUQD2tG/r1jigBm3TDVz3GWMCi9MawXuQrlfGTmamgCYjP6cgFtByvxUDYRD77WePL5UU8CzoD75WGrUwwIt8aTUQLA9ryJq3nfoRFNHqzv8/ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0436; X-MS-Office365-Filtering-Correlation-Id: 49968047-3dc6-430c-ad50-08d31c6b6b70 X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;20:x3M/bsw/DdtCas1vdWNm2qXNkn+gTVisW2PG28QR4aeJrCP+LJ2Vj/2W6ASQX9UjDoNkwiiLQcSbHpx22xYEoKY6UagnlYEc1OtUT9OcMHH0CMCP2sUnLQVXe7puuwiVCB3V0VrBhGFSC51FHgAwZ6fJfIiQu16d2d54KP+pLhmgiwvXrjRDRE+YLbQed6nyZjv4+eepEh6mD6frATe3FE7z1KMJtOFcuospC84UHNlSRmAQEyjGqNr9ufS85dBwruE1z0E2RpJIpjw+HkHISuV0IUbrsqlrmR7OJcMEh4ralxgeLSp26/17BSSArr0YLVLGCDOpgOc/JrrCUBC8dxkyTDhY8xpvloAJVJmK8rl9joZNYMhHcHHIeMfDagG852ekfu+d2slQ7aKmyB70gPITyKzgn9Oo2MLnsgIBC8Sn+nm35HCJ9IsyCPmrKNVRTLopSz6wt+Ux2b3LvxK5SFngQwezs6dpRflUtUT1yZLJNp0enUZjUCgpZgLxK328;4:XVyd9/N/o3ynhBtGrvAEJ/og/HGX3tAnxjlJaHLrKFU2NC0/lauiLkm0wMnMUQHjUg9lRUrShpEaCPTvD5vn+8rvSfjG3EkA5B08H5jo3qPSVStUZYg0AMTLbxdVXskk+yjkVTBhLuG33eA6QhR/c1bj1BEp+HcGAVOXs+uS78nqz63ihq40SM799ZMBP5KBFdGtH5lJQG4losV93Ro/Fyx6gxOBWndYrU7l0VDPqqYE4l0KgEEYP2INDIp+TDxOmKz3fBSXwQU1Q84/F1RrFxbH0pPibnSLV/rHUxMoXwg23okzdl28+4OrF+x+i6ERfOvC5tcr10xvHRNE80kDl/u9osshOKSENuwPLYtGehbz1W8gWRHP5gzQ0w8sQFEJL08il+3oB9ySu0ThFx00ysVMeENL2FKO3CnKzLaVKI8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046);SRVR:BLUPR12MB0436;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0436; X-Forefront-PRVS: 08200063E9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(24454002)(377454003)(189002)(199003)(479174004)(54164003)(5008740100001)(80316001)(59896002)(122386002)(5001960100002)(64126003)(23746002)(83506001)(33656002)(65816999)(230700001)(65806001)(47776003)(110136002)(66066001)(1096002)(2950100001)(105586002)(42186005)(19580395003)(2906002)(106356001)(76176999)(586003)(50986999)(97736004)(40100003)(5004730100002)(86362001)(87976001)(4001350100001)(36756003)(65956001)(101416001)(92566002)(81156007)(6116002)(77096005)(87266999)(50466002)(4326007)(19580405001)(3846002)(189998001)(54356999);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0436;H:[10.236.18.83];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR12MB0436;23:1JtYP+ENvKE6PZlTGVRbnUIbIp7+KmEoGGGZQ?= =?Windows-1252?Q?uyLvzvyAo2nJ7wUAnfQm2++PwtFyUvgWBUm886MX9P9s7/1ld2XBsVyc?= =?Windows-1252?Q?I0px5O1L7FeWYMHoPgQ/ZCOb89SaBX68cd+eO2RvnFV94/Um0dkUXkas?= =?Windows-1252?Q?lchOdILNYp56+Q/8DdCasThjUVdxZ9VQG13gUHbXyEiqpYTl5hzL45fu?= =?Windows-1252?Q?AtnIAW1ZUnhfUFdfEzurSCTbh2PPymYMFh/3BfupQyk6ENtu1aZd19WW?= =?Windows-1252?Q?zbcS7/9bziUBiDuOQjkbxqpd+TDlGPwy9zTh8HN5Rdj5bDwqYh4i2J3L?= =?Windows-1252?Q?AM+eVviEVn2MWV/C7uaJAkfR6PI/FBOLzuGDRm18OrKTLCoCBZYDjqMX?= =?Windows-1252?Q?+qQVwhiDwE0Ae4hUzUIJZjuaFrcr04W5bHV6KJWtUdw3pyxm2aq+ZYtY?= =?Windows-1252?Q?ERfst8q1iYP68Y5GHMfPhyIV6XYedy6NUFJWCngKkj7ZNZdFtcBWOPV5?= =?Windows-1252?Q?q8kqUsylq9OZ6W9mWZOxKBCsIZI4Pu5LrE9tK4/wHfzNW6pOWbKOoyaH?= =?Windows-1252?Q?FAtsThSaJH6trA5r7n9vi2A36IBGcFxQ59S0wQDghIc+2Nnv8VgzaXU5?= =?Windows-1252?Q?Q86lznXSBmp/8kUuSmRy0l88X8FqOm0pNtZuv5IzZns9yr3PemTOaLhM?= =?Windows-1252?Q?xdX0oxy7MDZZLoTJZi/nv4pB91X8omL74wBjkUEJLKYvUNp2P4yGN4iY?= =?Windows-1252?Q?nrWK/coEWOoPw8luia0c9N/NyJtaaq0nlmcvozXVwALhhhbhiKELoXuE?= =?Windows-1252?Q?zFurI5o8CMAo3TFNyHn5LdZdcwhEv+dk+golEeRh6AD2AGE4L4JjWuVp?= =?Windows-1252?Q?YTsFmpa1yecGJ7jb9YzecTMsBtxVd4s43rc9r7TGHsBs6nvwwCvY0hDN?= =?Windows-1252?Q?mkwLNGegdULGAfE18SYvzhqEA11sAVmrK9Ro8rlyJG/0qzRuVSww6gxe?= =?Windows-1252?Q?FN1uaOEbMSdEBsGpPaHfhrtawqgDXrOO9Dka35Xw5sZnISJySvP732Kn?= =?Windows-1252?Q?Uc8fhlQWpjHw2ev/fSJMonMxZytk9FnnEGS/QJBL0t+tbRReUz1OWo+S?= =?Windows-1252?Q?a0J8jE65/J07kaFb0T84b0dLyv6/VwxDrWMVeap+I2gcQSKCYNcfTMii?= =?Windows-1252?Q?DBPFlS032VC4QqXiOAmPP0TyhWzFZPfF2h1t+3aE436bRFTNBLKNp/eK?= =?Windows-1252?Q?9e+SugcfFvES+5bSSJbaC0QxXqmDzioYuht/c1K8j7OaqEN02h0EqSZ5?= =?Windows-1252?Q?V8zn5Mk7BA2SZJK7FSQsMK0rt8a44EoSEdhuHQiKZ+tFsHLem7DMzC8F?= =?Windows-1252?Q?ClN09hLiCnD7QXIycTI7zW9z0wPGcF956oTXPlilVmXHNxd5/dkLpxHj?= =?Windows-1252?Q?SlMkGoWFYXIzbWCNceP?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;5:iCiOzHttsDk3TdV8SrMZcT92YkSzOzYapLbPQ4LLgub9O4YnIFvh3fXe1QdyAoXk1f1pg5Sm4fiafq5gH5KVN0/az8B2HiAMlO0M/3DK0trGWq5sCJMSEwZbkBlmTHgBkmYid73573au8RmPSKvKuQ==;24:Qax9LDIabxBWpFUW5o2YzDaQIV9/M5eUEuhURi7uqL26BTcrJoYNM3NvxVIPJNWbpzvRVYqMn+biprTSFWQ7iGqFceNbAQWxmrG09uq987s=;20:zyDaVZF9VPn5ZPDV1kuQMZ9dTn1N7C28yALOL/a7duQDbLX0h+CLo3uSRHP0TqUbJz05xBnUc+YtimP5Ytn99VU7AIvMtpmHeWCL8ZD3fH0i/CHzGmL2hnOtWX7qL8AIuCvZ75aV7khjjfyKiCSlN0J1KTD0epqtX8UwUSSUzkLvNsa19pnaSVp3psHK8eR2EeZGyBDh46K+cZ+oYHy/CLv4X1+ZY6YaQXZRblyuwk73FxFZNKGzfBFfDawGFzPS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2016 22:46:46.4465 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0436 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/10/2016 2:38 AM, Wolfram Sang wrote: > On Mon, Jan 04, 2016 at 09:17:35AM -0600, Suravee Suthikulpanit wrote: >> The current driver uses input clock source frequency to calculate >> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not >> currently have a good way to provide the frequency information. >> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used >> to directly provide these values. So, the clock information should >> no longer be required during probing. >> >> However, since clk can be invalid, additional checks must be done where >> we are making use of it. >> >> Signed-off-by: Mika Westerberg >> Signed-off-by: Suravee Suthikulpanit >> Tested-by: Loc Ho > > Applied to for-next, thanks! Also thanks to all reviewers and testers. > Thank you, Suravee