Re: [PATCH 8/9] perf build: Select all feature checkers for feature-dump

Jiri Olsa
2016-01-14T10:18:22Z

On Wed, Jan 13, 2016 at 12:17:21PM +0000, Wang Nan wrote:
> Set FEATURE_TESTS to 'all' so all possible feature checkers are'
> executed. Without this setting the output feature dump file miss
> some feature, for example, liberity. Select all checker so we won't
> use a incomplete feature dump file.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/Makefile.perf | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 5d34815..a199fc4 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -166,6 +166,11 @@ endif
> endif
>
> ifeq ($(config),1)
> +ifdef MAKECMDGOALS
> +ifeq ($(filter feature-dump,$(MAKECMDGOALS)),feature-dump)
> +FEATURE_TESTS := all
> +endif
> +endif

please put the changelog comment in here as well

thanks,
jirka