From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755902AbcANFcv (ORCPT ); Thu, 14 Jan 2016 00:32:51 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:10265 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbcANFct convert rfc822-to-8bit (ORCPT ); Thu, 14 Jan 2016 00:32:49 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 13 Jan 2016 21:34:49 -0800 Message-ID: <56973321.9030209@nvidia.com> Date: Thu, 14 Jan 2016 13:33:21 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thierry Reding CC: , , , , Subject: Re: [PATCH V1 01/10] thermal: tegra: move tegra thermal files into tegra directory References: <1452671929-32740-1-git-send-email-wni@nvidia.com> <1452671929-32740-2-git-send-email-wni@nvidia.com> <20160113142418.GA2588@ulmo> In-Reply-To: <20160113142418.GA2588@ulmo> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: DRBGMAIL103.nvidia.com (10.18.16.22) To HKMAIL101.nvidia.com (10.18.16.10) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thierry, thanks for you comments, will fix them. On 2016年01月13日 22:24, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Wed, Jan 13, 2016 at 03:58:40PM +0800, Wei Ni wrote: >> Move tegra soctherm driver to tegra directory, it's easy to maintain >> and add more new function support for tegra platforms. > > Please use the proper spelling "Tegra", except where you refer to > directory or file names. > >> This will also help to split soctherm driver into common parts and >> chip specific data related parts. >> >> Signed-off-by: Wei Ni >> --- >> drivers/thermal/Kconfig | 15 +++++---------- >> drivers/thermal/Makefile | 2 +- >> drivers/thermal/tegra/Kconfig | 9 +++++++++ >> drivers/thermal/tegra/Makefile | 6 ++++++ >> drivers/thermal/{ => tegra}/tegra_soctherm.c | 0 >> 5 files changed, 21 insertions(+), 11 deletions(-) >> create mode 100644 drivers/thermal/tegra/Kconfig >> create mode 100644 drivers/thermal/tegra/Makefile >> rename drivers/thermal/{ => tegra}/tegra_soctherm.c (100%) >> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> index c463c89b90ef..7984cba6b340 100644 >> --- a/drivers/thermal/Kconfig >> +++ b/drivers/thermal/Kconfig >> @@ -254,16 +254,6 @@ config ARMADA_THERMAL >> Enable this option if you want to have support for thermal management >> controller present in Armada 370 and Armada XP SoC. >> >> -config TEGRA_SOCTHERM >> - tristate "Tegra SOCTHERM thermal management" >> - depends on ARCH_TEGRA >> - help >> - Enable this option for integrated thermal management support on NVIDIA >> - Tegra124 systems-on-chip. The driver supports four thermal zones >> - (CPU, GPU, MEM, PLLX). Cooling devices can be bound to the thermal >> - zones to manage temperatures. This option is also required for the >> - emergency thermal reset (thermtrip) feature to function. >> - >> config DB8500_CPUFREQ_COOLING >> tristate "DB8500 cpufreq cooling" >> depends on ARCH_U8500 >> @@ -380,6 +370,11 @@ depends on ARCH_STI && OF >> source "drivers/thermal/st/Kconfig" >> endmenu >> >> +menu "Tegra thermal drivers" >> +depends on ARCH_TEGRA >> +source "drivers/thermal/tegra/Kconfig" >> +endmenu >> + > > I think it'd be more idiomatic to only source the file here and move the > menu declaration and the dependencies into that file. Perhaps also make > the menu description "NVIDIA Tegra thermal drivers", I think we've been > using that consistently elsewhere. >> diff --git a/drivers/thermal/tegra/Kconfig b/drivers/thermal/tegra/Kconfig >> new file mode 100644 >> index 000000000000..a6e6cd4528dc >> --- /dev/null >> +++ b/drivers/thermal/tegra/Kconfig >> @@ -0,0 +1,9 @@ >> +config TEGRA_SOCTHERM >> + tristate "Tegra SOCTHERM thermal management" >> + depends on ARCH_TEGRA >> + help >> + Enable this option for integrated thermal management support on NVIDIA >> + Tegra124 systems-on-chip. The driver supports four thermal zones >> + (CPU, GPU, MEM, PLLX). Cooling devices can be bound to the thermal >> + zones to manage temperatures. This option is also required for the >> + emergency thermal reset (thermtrip) feature to function. >> diff --git a/drivers/thermal/tegra/Makefile b/drivers/thermal/tegra/Makefile >> new file mode 100644 >> index 000000000000..8c51076e4b1e >> --- /dev/null >> +++ b/drivers/thermal/tegra/Makefile >> @@ -0,0 +1,6 @@ >> +# >> +# Tegra thermal specific Makefile >> +# >> + >> +# Tegra soc thermal drivers >> +obj-$(CONFIG_TEGRA_SOCTHERM) += tegra_soctherm.o > > I personally don't think these comments are helpful. They're really > redundant given that they're in a Makefile within a subdirectory of > drivers/thermal. > > Thierry > > * Unknown Key > * 0x7F3EB3A1 >