From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753217AbcANJZr (ORCPT ); Thu, 14 Jan 2016 04:25:47 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36033 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752635AbcANJZo (ORCPT ); Thu, 14 Jan 2016 04:25:44 -0500 Subject: Re: [PATCH] clocksource: ftm: select CLKSRC_MMIO To: Arnd Bergmann , Thomas Gleixner References: <11970328.RVc8t0Mk1C@wuerfel> Cc: linux-kernel@vger.kernel.org, Xiubo Li , Shawn Guo , Sascha Hauer , Stefan Agner , linux-arm-kernel@lists.infradead.org From: Daniel Lezcano Message-ID: <56976994.2060205@linaro.org> Date: Thu, 14 Jan 2016 10:25:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <11970328.RVc8t0Mk1C@wuerfel> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/14/2016 12:02 AM, Arnd Bergmann wrote: > The ftm clocksource driver does not build if CLKSRC_MMIO is disabled: > > drivers/built-in.o: In function `ftm_timer_init': > (init.text+0xd324): undefined reference to `clocksource_mmio_init' > (init.text+0xd484): undefined reference to `clocksource_mmio_readl_up' > > This adds the same 'select' statement that the other similar drivers > use. Prior to allowing this driver to be enabled with COMPILE_TEST, > it was apparently unused. I'm not entirely sure who is using this > hardware, but it certainly can't hurt to ensure it builds cleanly. Hi Arnd, Thanks for the fix. It is already in Thomas's tree [1]. It has been merged in tip/timers/urgent. You will have to wait a bit this branch to be merged with tip/timers/core. -- Daniel [1] https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=timers/urgent&id=03724ac3d48f8f0e3caf1d30fa134f8fd96c94e2 -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog