From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753080AbcANJyR (ORCPT ); Thu, 14 Jan 2016 04:54:17 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:54622 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751897AbcANJyL (ORCPT ); Thu, 14 Jan 2016 04:54:11 -0500 Subject: Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410 To: Linus Walleij References: <1452531649-14940-1-git-send-email-linux@roeck-us.net> Cc: Kukjin Kim , Krzysztof Kozlowski , Russell King , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , "linux-kernel@vger.kernel.org" From: Guenter Roeck Message-ID: <5697703F.8040801@roeck-us.net> Date: Thu, 14 Jan 2016 01:54:07 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/14/2016 01:02 AM, Linus Walleij wrote: > On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck wrote: > >> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"), >> all users of struct bgpio_pdata depend on GPIO_GENERIC. >> >> This results in the following build error. >> >> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: >> excess elements in struct initializer >> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: >> (near initialization for '(anonymous)') >> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error: >> invalid use of undefined type 'struct bgpio_pdata' >> >> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct") >> Cc: Linus Walleij >> Signed-off-by: Guenter Roeck >> --- >> I don't know if this is the correct way to fix this problem. >> If not, please consider this to be a bug report. > > I think this is fixed by Arnds patch: > http://marc.info/?l=linux-gpio&m=145237423205247&w=2 > > Can you verify that? > Correct. Guenter