From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753062AbcANJ7x (ORCPT ); Thu, 14 Jan 2016 04:59:53 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:3204 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbcANJ7v (ORCPT ); Thu, 14 Jan 2016 04:59:51 -0500 Message-ID: <5697717F.20407@huawei.com> Date: Thu, 14 Jan 2016 17:59:27 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jiri Olsa CC: , , , , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim Subject: Re: [PATCH 3/9] perf build: Test correct path of perf in build-test References: <1452687442-6186-1-git-send-email-wangnan0@huawei.com> <1452687442-6186-4-git-send-email-wangnan0@huawei.com> <20160114095713.GB31454@krava.brq.redhat.com> In-Reply-To: <20160114095713.GB31454@krava.brq.redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.5697718F.0094,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 56b52fa3c62b12d90edabef08ca4603d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/14 17:57, Jiri Olsa wrote: > On Wed, Jan 13, 2016 at 12:17:16PM +0000, Wang Nan wrote: > > SNIP > >> +test_make_python_perf_so := test -f $(PERF_OUT)/python/perf.so >> >> -test_make_perf_o := test -f $(PERF)/perf.o >> -test_make_util_map_o := test -f $(PERF)/util/map.o >> -test_make_util_pmu_bison_o := test -f $(PERF)/util/pmu-bison.o >> +test_make_perf_o := test -f $(PERF_OUT)/perf.o >> +test_make_util_map_o := test -f $(PERF_OUT)/util/map.o >> +test_make_util_pmu_bison_o := test -f $(PERF_OUT)/util/pmu-bison.o >> >> define test_dest_files >> for file in $(1); do \ >> @@ -244,7 +246,7 @@ test_make_perf_o_O := test -f $$TMP_O/perf.o >> test_make_util_map_o_O := test -f $$TMP_O/util/map.o >> test_make_util_pmu_bison_o_O := test -f $$TMP_O/util/pmu-bison.o >> >> -test_default = test -x $(PERF)/perf >> +test_default = test -x $(PERF_OUT)/perf >> test = $(if $(test_$1),$(test_$1),$(test_default)) >> >> test_default_O = test -x $$TMP_O/perf >> @@ -264,7 +266,7 @@ endif >> >> MAKEFLAGS := --no-print-directory >> >> -clean := @(cd $(PERF); make -s -f $(MK) clean >/dev/null) >> +clean := @(cd $(PERF); make -s -f $(MK) O=$(PERF_OUT) clean >/dev/null; make -s -f $(MK) clean >/dev/null) > what's the second make clean for? I want to ensure the source directory is also clean. Looks like I forget 'O' would be passed to the second make also... > thanks, > jirka