From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753492AbcANKOx (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jan 2016 05:14:53 -0500
Received: from [119.145.14.65] ([119.145.14.65]:1163 "EHLO
	szxga02-in.huawei.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org
	with ESMTP id S1753013AbcANKOt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jan 2016 05:14:49 -0500
Message-ID: <569774EA.30008@huawei.com>
Date: Thu, 14 Jan 2016 18:14:02 +0800
From: "Wangnan (F)" <wangnan0@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Jiri Olsa <jolsa@redhat.com>
CC: <acme@kernel.org>, <linux-kernel@vger.kernel.org>, <pi3orama@163.com>,
        <lizefan@huawei.com>, Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 3/9] perf build: Test correct path of perf in build-test
References: <1452687442-6186-1-git-send-email-wangnan0@huawei.com> <1452687442-6186-4-git-send-email-wangnan0@huawei.com> <20160114100445.GD31454@krava.brq.redhat.com>
In-Reply-To: <20160114100445.GD31454@krava.brq.redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090203.569774F8.000B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 5763813fcac9ff47b9fd58892c5472bb
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/1/14 18:04, Jiri Olsa wrote:
> On Wed, Jan 13, 2016 at 12:17:16PM +0000, Wang Nan wrote:
>
> SNIP
>
>>   	( eval $$cmd ) >> $@ 2>&1 && \
>>   	rm -f $@
>>   
>> +KBUILD_OUTPUT_DIR := ../..
>> +ifneq ($(O),)
>> +  KBUILD_OUTPUT_DIR := $(O)
>> +endif
>> +
>>   make_kernelsrc:
>>   	@echo "- make -C <kernelsrc> $(PARALLEL_OPT) tools/perf"
>>   	$(call clean); \
>>   	(make -C ../.. $(PARALLEL_OPT) tools/perf) > $@ 2>&1 && \
>> -	test -x perf && rm -f $@ || (cat $@ ; false)
>> +	test -x $(KBUILD_OUTPUT_DIR)/tools/perf && rm -f $@ || (cat $@ ; false)
> do you miss one extra /perf in here? like it should be
>
>     test -x $(KBUILD_OUTPUT_DIR)/tools/perf/perf

Right. Will fix.

Thank you.