From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755849AbZBSVLc (ORCPT ); Thu, 19 Feb 2009 16:11:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756359AbZBSVLH (ORCPT ); Thu, 19 Feb 2009 16:11:07 -0500 Received: from web110612.mail.gq1.yahoo.com ([67.195.13.203]:46290 "HELO web110612.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756074AbZBSVLF convert rfc822-to-8bit (ORCPT ); Thu, 19 Feb 2009 16:11:05 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; b=42Z2QrAPDQCT1ktskQGIPKMF2HoWTXDqeSMZ5JtSZG83lkDz5/kXxzr7wHNW/NSyVUagnW8kRMOhjYftupDGJx/72vbtD1mQNv4rMggYwTONrGkIX1jzBH2Lcc9r+pp2OeV/4ihlZtOIDjlng2q7f59vWCeVI/B5TO1yGRYDTw0=; X-YMail-OSG: ItJSeUQVM1muFQhBK1cq5ZbN.Dczaa8UCzWjqcRBqlaVk3.wFW70DtDJtMlcOnzkrLEXuRcRZAdYfcFO0Ue0AAxtt1GAwrQZiWcJYSqSpMyWSFWrqRFprMNC28zEkpa.8pEg5OursKBkO.wRPnLKjJmOHIQK1F2J79ziEHEi8OR5Fb2xAfezD.atDV4rIaZLguokUoQtjBGJHBq25AMDqNgEolgUfNUEH5N00Yr3iA-- X-Mailer: YahooMailRC/1155.45 YahooMailWebService/0.7.260.1 Date: Thu, 19 Feb 2009 13:11:03 -0800 (PST) From: Sitsofe Wheeler Subject: Re: [SCSI][REGRESSION][BISECTED] Disk errors loop forever in 2.6.29 To: James Bottomley Cc: Alan Stern , linux-kernel@vger.kernel.org, rjw@sisk.pl, Ingo Molnar , linux-scsi@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Message-ID: <56979.43325.qm@web110612.mail.gq1.yahoo.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: James Bottomley > > Can you try this patch ... it was something I meant to get into 2.6.29 > but forgot about. The key problem that you seem to be hitting is that > the requeue evades the timeout check. Moving the timeout check to block > should fix that. Even by itself this patch works although the behaviour is now different to that of 2.6.28. Whereas in 2.6.28 it would timeout very quickly (after about 1 or 2 seconds) it now times out after 30 seconds (initially I hadn't realised that it would be so much longer). The other difference is that the failure becomes cached - trying to reread the same area using dd instantly fails from now on without any more disk IO/kernel error messages until echo 1 > /proc/sys/vm/drop_caches is issued. Before it would always go straight to the disk for the unread section and the kernel spew would be repeated before the failure. I guess if this is new intended behaviour then all is well - it's just different and slower/faster :) Tested-by: Sitsofe Wheeler