From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755068AbcANOjc (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jan 2016 09:39:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59586 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752322AbcANOjb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jan 2016 09:39:31 -0500
Message-ID: <5697B320.6010003@redhat.com>
Date: Thu, 14 Jan 2016 09:39:28 -0500
From: Prarit Bhargava <prarit@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Petr Mladek <pmladek@suse.com>, Thomas Gleixner <tglx@linutronix.de>
CC: linux-kernel@vger.kernel.org, John Stultz <john.stultz@linaro.org>,
        Xunlei Pang <pang.xunlei@linaro.org>,
        Baolin Wang <baolin.wang@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tejun Heo <tj@kernel.org>, Peter Hurley <peter@hurleysoftware.com>,
        Vasily Averin <vvs@virtuozzo.com>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 0/2] printk, Add printk.clock kernel parameter [v2]
References: <1452688466-14877-1-git-send-email-prarit@redhat.com> <alpine.DEB.2.11.1601131443380.3575@nanos> <569660FA.2020802@redhat.com> <alpine.DEB.2.11.1601131550410.3575@nanos> <20160114125238.GU731@pathway.suse.cz>
In-Reply-To: <20160114125238.GU731@pathway.suse.cz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 01/14/2016 07:52 AM, Petr Mladek wrote:
> On Wed 2016-01-13 18:28:50, Thomas Gleixner wrote:
>> You can solve the whole business by changing the timestamp in printk_log to
>>
>>    u64	    mono;
>>    u64	    offset_real;
> 
> This is not so easy because the structure is proceed by userspace tool,
> e.g. crash, see log_buf_kexec_setup(). We would need to update all
> the tools as well.
> 
> 
>> and have a function which does:
>>
>> u64 ktime_get_log_ts(u64 *offset_real)
>> {
>> 	*offset_real = tk_core.timekeeper.offs_real;
>>
>> 	if (timekeeping_active)
>> 		return ktime_get_mono_fast_ns();
>> 	else
>> 		return local_clock();
>> }
> 
> A solution would be to apply the offset_real immediately. I wonder if
> any tool expects the messages to be sorted by a monotonic clock. In

/var/log/messages from systemd will have to be fixed, but that's something that
was brought up previously (and IMO should be trivial based on the value in
/sys/modules/printk/parameters/time).

> fact, it might be useful to see that some messages are disordered
> against the real time, e.g. because of the leaf second.

I kicked a leap seconds during my testing (I have been running tests from
/tools/tests/selftests/timers) and didn't see anything strange with both a stock
leap-a-day.c and a modified leap-a-day.c which only does leap insertions.

P.

> 
> Best Regards,
> Petr
>