From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754899AbcANPBO (ORCPT ); Thu, 14 Jan 2016 10:01:14 -0500 Received: from mout.web.de ([212.227.17.12]:53653 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752840AbcANPBM (ORCPT ); Thu, 14 Jan 2016 10:01:12 -0500 Subject: [PATCH] fsl/fman: Delete one function call "put_device" in dtsec_config() To: Andrew Lunn , Dan Carpenter , "David S. Miller" , Igal Liberman , netdev@vger.kernel.org References: <5696BFAD.9030905@users.sourceforge.net> <20160113213537.GD4399@mwanda> <20160113220923.GE5527@lunn.ch> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5697B81E.4050303@users.sourceforge.net> Date: Thu, 14 Jan 2016 16:00:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160113220923.GE5527@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:aExCP38D48r/wfipXnXIGNA31AvfXLjZtHUDDKI9DTsyBDpvYAi bGSDQ1CdBjPsyFiK7M7OTQdkX4IIu3jAwq0EzWN0XHZjr8hCwncTe/koh22RPmjWjfPcDE7 14KEqICDtksTqt9PVhK4sckHE9I/IGt+t0iHa60XAh8Qn01zUIHrZzFS6EkQPtp50YWjA/o EdnV/Q2dKwxar+pL2TdhQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:OTuROWeM52U=:TmRSX+blWXncvBo+mNE/HF XVEZ8R3AdB/D3/9bZlG/q3VmvCE5iBJEJeTmzrYgYUEZn/U2/aMrKvrK34yFgNmjMYnMmBelT wUv1CuW0DZW43/B4jvoODYSuuZCBUqTfGL4vxAlr0WiSnQw22G7pngULw+NR4yPWrLeFnEcZ2 pFHebGhAyetRWh5CD2lFRAIn+giyfTtXMvNGO1rTIVH9IRYliCm4Ph9Ii4fmeMDMQGDHLOFoQ AvKtHVDh7uM/MK1ex6DxRf4WHkC4dgdmh61wpZJtACBKeqOU4q9yQYpvNV0hjUmWsymiT+AyE Mw6Z4QI5apiJu8Nq3UmzmR5QrmkhP4JeV51NoBr+zh6uk26gwuxyj8yJU12QbBbHh1F6pFGNd 26LKYhszFurazsxcIQJkmxV+Nq/HjqYGA91Svn27E2Luum0LkWHodSsoH6tO64EWxwrvperUB N/7eHY7EvnGB/ggzYhyHD9vZDBqcFUTBjcea2MLuf2gIuO/Oh74rjEoGjP4gFWQ5rlma+wzkL 0NuAuTlgQBgICHKo2DSfwFWE+wNfCYeE+Rkgyrxxv/bYggc9laNzNOlzOPbLVHHgsI7Rk7FvO mUgGe756XYckwJVmEDQNGFrduqZfKZtvgQujy3rd27Dz5/venJC8EzIn+emal0riaoHgx8CYm Al8FvSZ6cwX3gR3qDSlzX2zqo0mngHpFqm3ja8BcaCRuEutmnFWQN1JkuQMDvNlwWy9WdQ7lw 3YGXxr4bkZj2X6SQ6jDemTnbB7w2xDu4Au2RQwG6B1QFSS2X5NVlwCV3XFHOoiMEHX+NSd91e BmPiMy0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 14 Jan 2016 15:46:28 +0100 The Coccinelle semantic patch script "deref_null.cocci" pointed a problem out in the implementation of the function "dtsec_config". A null pointer was assigned to the data structure member "tbiphy" of the variable "dtsec" if a matching device was not found. A call of the function "put_device" was unnecessary then because a previous call of the function "get_device" was not triggered. Thus remove the function call "put_device" after the printing of the desired error message. Signed-off-by: Markus Elfring --- drivers/net/ethernet/freescale/fman/fman_dtsec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c index 6b1261c..7c92eb8 100644 --- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c +++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c @@ -1434,7 +1434,6 @@ struct fman_mac *dtsec_config(struct fman_mac_params *params) dtsec->tbiphy = of_phy_find_device(params->internal_phy_node); if (!dtsec->tbiphy) { pr_err("of_phy_find_device (TBI PHY) failed\n"); - put_device(&dtsec->tbiphy->mdio.dev); goto err_dtsec_drv_param; } -- 2.6.3