From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756305AbcANRel (ORCPT ); Thu, 14 Jan 2016 12:34:41 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:51048 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394AbcANRej (ORCPT ); Thu, 14 Jan 2016 12:34:39 -0500 Subject: Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support To: Michael Welling , Daniel Baluta References: <1452788708-3003-1-git-send-email-daniel.baluta@intel.com> <20160114165133.GA20246@deathstar> Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, lucas.demarchi@intel.com, eibach@gdsys.de From: Guenter Roeck Message-ID: <5697DC2A.5000801@roeck-us.net> Date: Thu, 14 Jan 2016 09:34:34 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160114165133.GA20246@deathstar> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/14/2016 08:51 AM, Michael Welling wrote: > On Thu, Jan 14, 2016 at 06:25:08PM +0200, Daniel Baluta wrote: >> The driver has sysfs readings with runtime PM support for power saving. >> It also offers buffer support that can be used together with IIO software >> triggers. >> > > It should be noted that the hwmon driver subsystem has support for this device. > > http://lxr.free-electrons.com/source/drivers/hwmon/ads1015.c > > The driver could likely be removed if this is accepted into iio. > The hwmon subsystem has an iio wrapper driver. > > http://lxr.free-electrons.com/source/drivers/hwmon/iio_hwmon.c > > The only hurdle is adding support for the ads1115 before removing the other driver. > Yes, plus one would hope that there are not going to be a different set of devicetree properties associated with the new driver, and that the new driver will support (at least) the same properties. You'll also have to make sure that only one of the two drivers can be selected. Guenter