From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756818AbcANWse (ORCPT ); Thu, 14 Jan 2016 17:48:34 -0500 Received: from mail-bn1bon0055.outbound.protection.outlook.com ([157.56.111.55]:60217 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754575AbcANWsb (ORCPT ); Thu, 14 Jan 2016 17:48:31 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O0YSOO-07-1R6-02 X-M-MSG: Subject: Re: [PATCH 3/5] x86/mcheck/AMD: Reduce number of blocks scanned per bank To: Borislav Petkov References: <1452809140-3328-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1452809140-3328-4-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160114223739.GJ19941@pd.tnic> CC: , , , , , , From: Aravind Gopalakrishnan Message-ID: <569825B6.6020507@amd.com> Date: Thu, 14 Jan 2016 16:48:22 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160114223739.GJ19941@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(479174004)(377454003)(164054003)(199003)(24454002)(189002)(106466001)(83506001)(36756003)(105586002)(101416001)(33656002)(189998001)(97736004)(586003)(1220700001)(77096005)(6116002)(110136002)(2950100001)(59896002)(65816999)(1096002)(4326007)(23676002)(3846002)(87266999)(50986999)(80316001)(65806001)(99136001)(76176999)(54356999)(65956001)(4001350100001)(64126003)(92566002)(47776003)(86362001)(2906002)(5008740100001)(11100500001)(230700001)(5004730100002)(50466002)(87936001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0856;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0856;2:e4kGKRdwlwi9CE+puO86o1HhPcHpxELHQnXI/vrmzgADL+A6h3onbJHYYrF0gsi2nLeSnqoRGlUltjxebCzfUQW2PxrYLlvZ5ASXDYFav9IK/ws3n5MywJDdVK0nAo69W5bLACatKHRC1Myts7yHBA==;3:XrWxcZ9Dp94xPOe/FKI8+x28PKzsUfg7jNb2R55CmW/K1Lk3XVbhdCmAKHddrGZNGOtemZ2xtME8GBFejT6e3I1ej9S5ondGsl/5S1SqXW0eY2DaJkNcgJBZuDPgBQ+WiZWxiFzGfGlmmYo/y7mRZ+CwwPuOJUGnHxob/yyEMf0fM6HadLl30Wg+oxFxOgot68xsFza1jWwGvg6ZGmlrf3TAgg1XKMSvHEF/IoASq7s=;25:nmX3RKOWQiwWe97SX4LuoEVPgXVhKoK6ufCRafw85q/BnAHAJdPpksKJTvAUzF8ijMoXpeRAsHEp5e3Lo0S06i9Hnfslvlm0xhwadLw+hubGB9pcenZFFPSrjyMixjydySukC5sN/SMp7KoEMXAKhYvgrVo1D2FpdGDYznzaGdEgT6PQpiUtpIWoMJpOpU+skT8BpQjGX5x2JdThJ5a87pwpzBzT9/zlK0SgEmElbARv2M2yoO84LIrxuUCIONYg X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0856; X-MS-Office365-Filtering-Correlation-Id: 88c25443-2e5c-4f18-42af-08d31d34d126 X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0856;20:gmQOin8aIbE2OUzaX2KXWlPZMg9KWh6nq2wRZNp1ijTMnvlKa86/jdVgPIH07jlf1k3wgz5JlpaNd4JD9moSTOpdaC1ARV7vXAxHiExx2djdUrs0E814gTFaRKXSS2zCUK7WA/62mM1199zyg+0VLlgjN2OVSv0yem8SPq/cfo1fydKzf421gDCStPgwjsTHvpi9b7VMSJ4FNMqVOfds45x4taibMRdXuN3GocCfE/lIfIViS/t4Tl24XumfqYMYxxTEfBg2Y5AqrFsNKXTWni/7nZjfZzAjP6lmt9F/cq7m857ih8Mq0B6q1PPFCU4oOOr9s0LIhusf4RyQx3ndmdIeKzsl0dKrpw3aCH5m43FYePPXmAPElq1UdV7vZgNXnmqghljpk86nhY4B3UlSgyClE1eJx0PNb7Wf+atPrD9bVXLuSz2usZHh/ZWDScQ5I3CFMRAaG++uB3vXcFCo1s8yajI5xfhjCxQCBztlBCIq3wuE2iqvTxtHjCp+/hpM;4:qWAnSkuOGkxywpdIWpgqRmRsvyqJOQW2w83kAtp+wA5a4gfcr5otWhf9KCr7T6pQ9JOa2czjqngRiaDxEf1UsfTrXLI0fa/N7femuk9j/q+Ejne0+9BTRaRtLPNllxkaZIITlzyOPd+41PDJba1xLh3jv9JLrQJd/pf1HN9VplY4p2SE2Le97uC12BXK1Sq33KicRJguKrVh+P6h+ImCqzUEKFbxSOGBoLrj+OElJmQeMj1SGNLkadcF/Hy8NV/WHceWXfULjq7UsCszvj58CO81AZRCDumVJvZuQZF3sxuUf8NLy/s3Wd5rQySZ33h8iz7BT9hY4Cp2XrY25v5W0sqaT65gUHr0gtyZR3sctff/Q3sLO9AWL3tChYw+X1q9uZI2nJOh9QoekLHJUs+mDasReODkN0Y2KshFpxcGU4OugYYQhTgXoX+B6SuXw+/D X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(13018025)(5005006)(13015025)(13017025)(10201501046)(3002001);SRVR:CY1PR12MB0856;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0856; X-Forefront-PRVS: 08213D42D3 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwODU2OzIzOnFoazRab0lXWEtXbzN6TU55QUllQ0NJWCs2?= =?utf-8?B?bGd4YlZLWFduSkVrQ3NtK09ZU3BQWGw0UExWZGRyMERqY3h3aGxXQ3FwRnBz?= =?utf-8?B?S01venBOWnV4TkY4Zk9kS0lxK255RDhZdnRyeXdhRm1rRURBZmZIeG15dHFj?= =?utf-8?B?K0VQajJ4dTNyOFpOQlNsa1ppNGdGVXBNcjB4bGRYbVRvM0JoQUZ3ZW9vb2h6?= =?utf-8?B?blRVTS9WTjJ1REQwdzdYTkI4aGhVTnE1R2RWMG9OblFudnZNanhVVXl1OFpF?= =?utf-8?B?S0RJNVl4MUUxWTZHL3l0QmFxcUVWZjJjU1JsTFQyRTRzKzRLZERnN1ZodlFG?= =?utf-8?B?Uk4wOGcxL1ZNV2RwdmdMNC95QmxzeThaR1pIdVpjQVdTcjlUVTV5VmtaNzRh?= =?utf-8?B?ejNSNk1Zc1BPSDNZbU1NcGtRUUZyRFNtdGJUaTBuc01CWGw3WTVQS2d5SWd5?= =?utf-8?B?TkRFQm9vMDNoRmdJRHNvam4yNUQ5c1JySjdvVkUzS2hqWEVpVURLSUVSTnFm?= =?utf-8?B?QUJ2eE1LbndyZWRJKzA3S0ZMN1BkQmVxVVVsSVJTOGdUT2o5K0lJTHA0bFdp?= =?utf-8?B?My9FU0dqbnFpU3ljQUFsemllTnJIMzBVRGRISmFnZWVXeUVvZU01MHR0Q3F2?= =?utf-8?B?K29DcVZKdElzUm0xdTBad20vVEhXQ1Z4L1NJVzcxdk1QOW5SQldCd2pqQklJ?= =?utf-8?B?YlQ5ZC8xSFRyV2NjUStCN1h3aDRyOGxaL1VjZ2phME8zOVpQWHZia3Bid0xs?= =?utf-8?B?MjAxVU9rV1ZCZ0V3d0FBTTdWWVd1Mko2QnRtSkpJSnRyWExmc0E2YytIcVlw?= =?utf-8?B?bVNKb1hlSmh5T1FCaDhtb0tub2N6NlZBSi95V3dMT0RSNERwamQ0Q2NuY2l4?= =?utf-8?B?elVua1BaaFh5YkgzZ0pvaUxMTlA1bmpLNHFqaGQwNWZtNFl5MnE3UkhsVzhJ?= =?utf-8?B?UU9PSytXVlRhR2d0SnZRYS9RMnhQZ3doNmRrb0dmTW1ERUgwcEpRVDNBNlhj?= =?utf-8?B?Z1NZa1BkY29UMUliS2ZwQjJialc0RjZ6MWZCelljcDVvdUtXbkQ0dTdRMDNR?= =?utf-8?B?My9TVnNRMEZ6Y0E5N1VNUW1RbzJFZzZxNUFpN0pNZ3J0TmNQemRGTkczNUIy?= =?utf-8?B?d2hBenpPMDkxMWlPUVo3SEkzYzNYM3pzejM1djM5N0ZRcDRrUW5hdGlacVVq?= =?utf-8?B?TkNza3ZZV2JyU0VnbjZZbExia2VhWVF5QTV0c3pzQTZ6MVNaeXNlS2pVZDJz?= =?utf-8?B?S0lPSmRNS1hvVUVlbjJ4MXczenR2QkwvOEFZL1V3VmtYeVNYYXpwQUhPYzV1?= =?utf-8?B?UmE0WDFiL0RXTGJ3R1ArZ3dhWVdWK2JlWDlMcGNNYUJHbmQ2OVdIYTNuSXdP?= =?utf-8?B?Nkx3QmZGV1dFTGovZEtqMnFUbEhBZWlIZVQyRHV0OFQwMkVEcThrVVlZTGFM?= =?utf-8?B?WU05bThBTStwNGx2Nk52UlNsd2FiZVB1OGxjZDJEKzFFT3U4MHpYRm92M2c4?= =?utf-8?B?RCsvVzg0eWZPVUxpTFcxbkd3NmpHdkFIeFFZY00yMDNZQ2VsV29IZWV0anFC?= =?utf-8?B?Z203a0NIdk10QUVDYjNHR3M3MUVJZTZ4a1JhNXE5R1E5YnMrNmMwSmhwMWRV?= =?utf-8?B?UkFMZllXZ1FtYVBrQUJkQ08vTGR4cDRjSUdrdkFWdms0bDUzVWNNeDRSOWY3?= =?utf-8?Q?Omtia8jEUEX7L4gSOc=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0856;5:ksxq6ll8uKP2enpq4MgWJ3V4tNgICm0pfdFO5nYt7koHC+Us/3cuw5XZkq4Xw66Cl39OQeI5A5o4xGEqSaufERni2Fb0US+XpcNTLRlv5+lSiNVwWEoc5HwqZlnbrpHHPBRj/qaivpqkXE2dKkcwzw==;24:hwNS4HODcTDJUmy48DqW+fXoMaePYW6iXlaqrimzXDJAZ3q4qjWaahMNO6B++jY/AEWSvPOZHuZIg02zcb1zVb4yK8cLuzkvhrseD9HARHc=;20:sjCoyagwfqmPs/ID8Wz+G6xTX8QoSTnOz2JksnpGnoVjBmBjTSKB7/k71utvfHLbiIdrTqgmO2yduKZI/jTqbPFF8I2oXiMJLm0Wt5EGxNwnl3lxMYCz8QFa0Pa6e4bWups/Eez/+az8h2n+ZPTFAc4NXJYNiEBCvhffZLZoVWXs5q2GS2t5xxO6EmZ/C+3HXzDHjILOnA+4XhbHf0EY6DYnOMncKpmiyMzFzG3NiPkFAwIW2b7JN3/fVroJqSLA SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2016 22:48:26.3353 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0856 X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0823;2:UcX4j23HmCQtKLRpvcd9pNUFiCQGWmq4i2iVnYQodIIlNzvia2t8b7qswgwfmHWwLVFSDeLZOnuspxRiSl1X2RaVxdLvNxOM/Q/fimm4of/kHoXlvuFb3pe+EQF/a+Z25vor5qdkJOw7VTF6HmCvFA==;23:mrZfi8/F00DliqSJlTqcLSxbtX3MljhOTVDPay8OkZqTgjxHPAYEuvbS29F3rqLkEzVahPcvNPyMRiu6WK2PrkSMA+bhmOw0zwK8Du/s4SEfkL01qKYpPwqbz9kkvidssZY/UlrA8hAFZIvpnLbm/ES33kKC+vmhYP72i1gvLE5GAMqfZ7F7AfgX23OTSmsu X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/14/2016 4:37 PM, Borislav Petkov wrote: > On Thu, Jan 14, 2016 at 04:05:38PM -0600, Aravind Gopalakrishnan wrote: >> >> -#define NR_BLOCKS 9 >> +#define NR_BLOCKS 5 > This doesn't look necessary to me. We do check MCi_MISC[BlkPtr] before > accessing that MSR. > True. But that BlkPtr logic also will undergo changes as it's interpretation for future processors is different. We are guaranteed to have all the MISC registers (all 5 of them) going forward. But we shouldn't be accessing MSRs beyond the 5th extended MISC register for each bank as that is the architectural boundary. Hence the change here. Thanks, -Aravind.