From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757118AbcANXIk (ORCPT ); Thu, 14 Jan 2016 18:08:40 -0500 Received: from mail-by2on0057.outbound.protection.outlook.com ([207.46.100.57]:49360 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756937AbcANXIi (ORCPT ); Thu, 14 Jan 2016 18:08:38 -0500 X-Greylist: delayed 3375 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Jan 2016 18:08:38 EST Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=temperror action=none header.from=amd.com; X-WSS-ID: 0O0YTM6-08-5DY-02 X-M-MSG: Subject: Re: [PATCH 3/5] x86/mcheck/AMD: Reduce number of blocks scanned per bank To: Borislav Petkov References: <1452809140-3328-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1452809140-3328-4-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160114223739.GJ19941@pd.tnic> <569825B6.6020507@amd.com> <20160114225359.GL19941@pd.tnic> CC: , , , , , , From: Aravind Gopalakrishnan Message-ID: <56982A6E.10000@amd.com> Date: Thu, 14 Jan 2016 17:08:30 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160114225359.GL19941@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(479174004)(377454003)(189002)(199003)(24454002)(164054003)(54356999)(5008740100001)(86362001)(11100500001)(2906002)(586003)(4001350100001)(50466002)(50986999)(76176999)(101416001)(110136002)(189998001)(93886004)(4326007)(2950100001)(33656002)(105586002)(64126003)(87936001)(92566002)(47776003)(106466001)(23676002)(65806001)(65956001)(5004730100002)(83506001)(36756003)(65816999)(97736004)(6116002)(1220700001)(1096002)(3846002)(230700001)(77096005);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0717;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0717;2:DF90gqf24Dnu9nuy7eY/X18enhpULZq/902VHBS7Ch17p0SLTjZDVM8qYaIgy1Px2Dhm8w7p+ztgWqZUoDQwjo3FsmgHIXd1Sovi0RJTxs9FQFXAwYNLg51z6E6BHu+fdMcRN8w7DQImmBFiGCATAg==;3:E64tbSIpW1SR492gzmfDN1pV+0AitLsqlfqH22rlTiZp+Bx4QtD7t+3bcMqKJ1mGXt/hBxs9Ag/+ejNs2tMBvoOBaLWzm33L6qszAy5LP5OzO/N6ESNIQvb2pyw2UBh8F9bEn2hymsXIZcSWPue3a6l0Wz69rmlnqgXt2PEiKuMr8jFk824JlT3WVf/eJnfEBt/IypgFX3g5yTeBT8kGj+B/36WFs0ShdWhmFNlQjYA=;25:TXAgEpI0OrKneJRj3eEQMrDPoGtQPDhCsFMJjYDhusLRBEAA9KsNpzH7/JHHoub7IcC9q1bwTk2gB1jRYIqnt3IUFf6l9Rdt/rdyNlcmW98NaYAehsRrD4fw5EJILCkSnHw9aZUZBC/39gmmYH6y/Y8l3Lp3rS5QDL2X05TyzvFFfaiL50eVjBxWj3EtUtSezKeloxdke7X+7ZYXqIKghOVFEPasMiLj7ZJBvaRbGw7TJHJ91tTe+VWiHv2A1Hyv X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0717; X-MS-Office365-Filtering-Correlation-Id: 44fb4201-6be1-4979-bdb2-08d31d37a108 X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0717;20:0ww4cinrFgH4WspVCvSZGNHXzBRydOU4o2W21yWAmWUtBBpcxGmqIN6YorrrtcrsfrKzTutHBt5jbu5RPmBJJzJaHi/YqRIRpNbXVHKXgbMzjBvrasyRTHX3lYq6a4MnM4UhoNaksuPLFEn3ZUVFoNuSbdYphpjFBQ1OxlgQvHCn/1GlhF1nzcCgL00NOBo3eXvOpeq2iQNa19c1p5c7PP7z5cF/86/DDEnNK8s/L5rTsE4OBfxq1q5qrqLdz/jlW2+l2JJTG5I8ac9tV4ZXRnDkKYA/sGhqagRJl+yy66n7DLfKEVz55KOrZpKv49exO34hg37cmEKJbjCqeMxex2rCva7tBr35ZUasUa0LA4UniN9f7oNXfeMQKg6ddgZDCP+RZqIb/4wcYK5YBRpQSCb49lfY1znxHmQzE2xlG4f/GCsIsMu+96ZrqFvED9Kg4VJCX8YIcR0L+vOUQjagIi8eRTTVEYfJyU/EI/h7bLlcSIqmn/Zwt9kY3yzK5Qin;4:vC1IwCl5NvV91fUhcqKYSG73lbafxe9dsSYqV7c7/399S/raUCiUqKj+/C5EASK1z7RtvXukOGRYNM7mHbPTHTonqpLt0ueyHw1BU9s4R0pqr+t4lIxKKI7tmqkAT6LPgYI23cW/+L08ly+AEusnarPJ64FoJmY2Nm5z7D3EXwNDKpq0K9dj7oYVmUVhwlL65QnksLTm3OLdlsY1DvZ5AomkuzeJsKjMcuLh1EAXAdtu7AGwxlmx71+YjhZtRNZ4M3Peio9xnO074bmFb57hu4tFUlx9PFZFb/hABKLCRRIekS0TOKKOxgwO0vWxcWZo4LtnCCWsl4q63ZnaDUJ/iBykZfGITmJYJotLkoOWxFk1H0YRqsbnVzNCxwpdr+o+CUn65nh9xZf8yS99Z/Z5jc7oX0afEbYIBZMee6ReHH+u4qDnvSPgajYyVXC6eOI2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(5005006)(13015025)(13017025)(520078)(8121501046)(3002001)(10201501046);SRVR:SN1PR12MB0717;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0717; X-Forefront-PRVS: 08213D42D3 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwNzE3OzIzOllBUEtJSUpsY29GMWh6UnEzRVRqUXROY21O?= =?utf-8?B?VmQzQ2hoY0dzYlhLa1k0R3RRaXlvam8rVUswdHoxTDlFU3B3MGtWV3J3Nmla?= =?utf-8?B?akZqMkY4dldxVGRFN1UzeVl1UkxOT21LcFVTdTdKcFR4Zlp3dU90aVphNTlx?= =?utf-8?B?RElsMHJoalRGaFlrS3dtZjRaQ200WTkrazcxdk02WFh2ekJKT0crczNyRnNH?= =?utf-8?B?OTFtelFsam16S0hqc3NuNHNjOXlBQllsbzF0TkRlYWJiK1BVbGd5MzQwUFl4?= =?utf-8?B?VXpPcy9PTGJXdWNIWm8vcGppYzU1NU5EcThXUHdqMUg1SCt2UG9QRWFORDFh?= =?utf-8?B?Ujc0TVQ5bGhRUmpTWTNkbEluSFNPWDFxWmI1MldpYVhCbWdKYjdVZldDT1hx?= =?utf-8?B?S0pJemE0Wi9UaC9ZaXBxZ0Yrd3dyc01RcDRLUGRaaEdVNldYRituall5OTNT?= =?utf-8?B?NGlaTHNTRjIzQkRKYmErb3I3V1R1cTZUSGw2dS9qOGc3aTc5TXN0cVVxbjI5?= =?utf-8?B?dTV4ZTVSUmVla2tudmtBdVpaSitRN1g3dXJUU0g1WGFtQTRLY3I5dkprQ0M5?= =?utf-8?B?a1lTU0tIOVRXRzFoL2d6anduMVBzWXB5ZCtiUFJUMkhHeGt5QTgyQ2lSMHNq?= =?utf-8?B?Nkw5SlpIeHo4WVhBVmlBZ1Iwc29PbEtBVnFqQWFzZk9GdGo4Mkk1ckhTNWIx?= =?utf-8?B?WHIweTN2ZHIrVW80YzRFbk12cjhWODNmcWJwZytNTGtFaStjU0hPbXJvRjZk?= =?utf-8?B?YzhqdlVOcUZPSHliNEpMQk1odC9hbUNHNDRQY2RSLytmNVVNNUF5REcwZUNU?= =?utf-8?B?TWRZNWRTVytGeTlpZVN4R0NnNWo5ZithMkhXTHRCU3J5YnBtVmFMQkg4L21B?= =?utf-8?B?dXBEUDl5ci9zZEs0M2tCcGR1YlVzdE5vSGtZMzI0S2pQZDRleCtZZ2h5NzRH?= =?utf-8?B?MnBCTEN6SE1TYlVhUlM3MDlkK09JL0ZrNHNPVkJZQ0tKSWpkOWIvVzZBdzZz?= =?utf-8?B?QXlJTkNvRnRxbzZYZ0tYcndKZEltbm1hSVVzRnpoWGFMSExOK2ZiV2poMktI?= =?utf-8?B?M2czK3NnTDhQN1l5bk5aRkdsL3JyelhvN1BPVm14U3BVdnlNcnpLR2ZCVDAr?= =?utf-8?B?OXYxcHRML3RtbkFsWFEzSFZKTDZCZURicU9aWHBHWlV5QjJ5NU13NFNXRldO?= =?utf-8?B?WEpOUXVaaHFqdFVUakVkNGwxR0E5OFV5ZkFmLzNIU2RGZzRCTlo4NUF6RmNl?= =?utf-8?B?a1A2K091RDB1di91QkxsRXU2emhJaFVSQ05WZXhEbXlSSVgxRVI1ZUgxMm9n?= =?utf-8?B?VHRuRldaREtSa3RtSXdjc1JhM25CMkYySkZObGVMUVF1Tk9saG82SDRnRWli?= =?utf-8?B?VkZqSGVhRC9WTTRKTlQ4cWdHUVlzeDc3MmlpaXFTMUpOWkpsZVF4WXVIUjgr?= =?utf-8?B?OGNhbzhSWGN5YVRoWEF1K3QyTS9wU1dUaU5laXh0SS9yRXRaSEJZQkJsdFdH?= =?utf-8?B?d2t4cHJEQlNzNjlOTTR0bFlVdG9saEIxb245ZG9kMGF1aGpNKy92SEtVMEow?= =?utf-8?Q?I9z+mWdgVeTkvhO6an35zss4HhMmelRtVb0tK8XVLFeo=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0717;5:4r48OQyj5Or6D9DGPSe/G8zZGSIUq3bmO3U8x0fmIVfKmmsXZtJVJNBnDMksJ8CElqLWDAJMKr2Z6MPC/vHB83wh25I2bSe5HsSgrWRf4j0E4CQ9hNM6OJQdoy3wwxy5TwrpA7teYtv1zMlWDmczbw==;24:zlSmrxQIung++yUMHsrhInCMP7plcHTe+OSiuOLOv6Za0x5nYo0zGkL4O93qlWo1xXNNMrwceN29ogCA3e5c3OK1JJqOT6YorHZcGFukvmg=;20:TdI+kGBZGe9+dVZ0tlez7QHs5L5fdf+g8XLuLSUk2ThXtJxVg2KzcU9hliByMzzdk2BnQ4DAVlKaE0Nkl8rsV+70BtL2NDx+qIWCZbB3MKiz5BEwLfBcnlFSrRfGSHorHb4uhYdZq+PeC0laSjBfF+U9LIJrNoCMYtR5y7DFfDZ2/Zg/3JLHWwnKWlAy1oS7zjfNKlu8TnB38CoUHFS7M1WXaKhxDVdgq5tMYLeuWdFDgvolSdUoeNmHPDMtwrBc SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2016 23:08:34.1327 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0717 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/14/2016 4:53 PM, Borislav Petkov wrote: > On Thu, Jan 14, 2016 at 04:48:22PM -0600, Aravind Gopalakrishnan wrote: >> True. But that BlkPtr logic also will undergo changes as it's interpretation >> for future processors is different. > But there still must be a bit there which says "this register is valid", > like MCi_MISC[63]. There is a bit to say if it's valid or not. > And so I'd very much prefer checking a bit (or bits) instead of relying > on defines. > > But we'd still need to know the last available MISC register for a bank to know when to end the loop right? Currently we loop over all the possible blocks- for (block = 0; block < NR_BLOCKS; ++block) { ... increment block address; .. } Here, we know we have to stop at block number 8 as that is the last MISC register that is present for a bank. In the same manner, we'd still have to know the last possible MISC register for future processors.. Thanks, -Aravind.