From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161066AbcANXNV (ORCPT ); Thu, 14 Jan 2016 18:13:21 -0500 Received: from mail-bl2on0072.outbound.protection.outlook.com ([65.55.169.72]:60981 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161000AbcANXNT (ORCPT ); Thu, 14 Jan 2016 18:13:19 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O0YTU1-07-2YU-02 X-M-MSG: Subject: Re: [PATCH 5/5] x86/mcheck/AMD: Set MCAX Enable bit To: Borislav Petkov References: <1452809140-3328-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1452809140-3328-6-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160114224606.GK19941@pd.tnic> <56982706.502@amd.com> <20160114225842.GM19941@pd.tnic> CC: , , , , , , From: Aravind Gopalakrishnan Message-ID: <56982B89.6080206@amd.com> Date: Thu, 14 Jan 2016 17:13:13 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160114225842.GM19941@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(199003)(164054003)(24454002)(479174004)(189002)(377454003)(5008740100001)(47776003)(5004730100002)(80316001)(106466001)(93886004)(83506001)(65956001)(105586002)(2906002)(50466002)(33656002)(23676002)(86362001)(64126003)(101416001)(4326007)(59896002)(2950100001)(87936001)(99136001)(230700001)(1220700001)(11100500001)(586003)(1096002)(6116002)(36756003)(76176999)(3846002)(50986999)(65816999)(65806001)(92566002)(87266999)(77096005)(110136002)(4001350100001)(97736004)(54356999)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0715;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0715;2:C6IhK90h5AKH2i0WX3mhIBLM9knT+4v2zCMNO8nhpTeTgvZ79VQhskPX/OXuBP481pIGRfWyCEZb9eNTDzluCg1rtpIdAiEfPySPUEFp2tgTcmVpKw93J6CoGqAF1Pd6eeqyPx+7LfqGgPlohbPjdA==;3:q4fEFNlA7VIEeRLA7mITiF7oTsTtYMhSsvlMRD2wYNpXkiDhZRM+qagAiqVHOQzLnxuCmzTVvAgaBX0RC3EuHgAGO0Su3uL29iwls0S+kNahfs6cHjdqTfUwLCzjT7x37B4T7DJxyIhecGAPVYJrq9HnY2VtUfCASNecC+lOqEt7htOFMAoHV02/xGqxi3qwAW6P7e+y/WhtiQoT3zWT8Jk7sLXZUfV6OGVqn78YiaU=;25:Js8KDn/2qfL/ETy+s5l8JXtcZhPMQockpufplutdmMC30cSriaPv9wWIKvhvwTZRxG9CofpVRssrT+jxWMsUg23MagoP9PUDloAxzenJwZbGqPE/jc1RWYiVV/NM5kNcTsKZh8vCNYb1d9y1rTuXGo4myoNbyuSJ/2YGvMjNQc+l6MvKNFtlzJPqelbZNML3AZSZ5ue/1WmQmGcH3+pESiZYLIyWKej/iborwzJdY7UD736McWl6blIhUnhh3r1Y X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0715; X-MS-Office365-Filtering-Correlation-Id: 145e3ab1-9e59-454a-8df8-08d31d38484f X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0715;20:SRUMJSIJlRQngmzbuQUCffrOh4GZnBVpxW2Z190Kyz+C/bWxj2FhiTxBYSWNDC3YbEedNsg+FYUbNHugfoJ5epavAvDnBjgTgNiWmpFID4zVlRmPvSK3D8LkkKaE9Y2Gf6k6cqMKHBTDU+1VPNdtyYO7tWzaeHBkpTy2UGDLjKeVj+a9FromPPzgCnWEQd7TzYmYh42pKxEhWih0kNCM5xtCLb8k0JhgtoKEkHGP/I+8Rwrdo0rmC1XWKj2y3/Nky3rprvitDqZmNFbS2/kPG2YCh6DYy60i815jPl3Spp8OX41FwL9CgV1qKePhuX5g1GGXTl5SPOBBWAC5HR8Rt9bOYOETEnCOdTxkHGsFilVwpzu7S2OF3frOPW9fHDP3DBLCbdJFF+vkUHoxpIKhpppDkqWmsG9eeyxHE1xuWPsYq++qdRZRCcljyfglwaq+84xfXFGrzZZWcJymPvaXtTJbsSCxVViEMe/HQAXl0JJLLdJL+5mb/in2lCuedpGL;4:IE0aquGXOTLygZT/hpRG1CfDEVS2BdaOtOe0yyOCJ1pm4BoO7/+gV/C4QrNwBE/PAA/6TH9fyMSImQvnHZtuGvHJrI5UBfIT/feFcgfCBYc8QX2/3zFezVfv0AFTr3NELd1Fg0+27qryESvM/VHFVt9gVeuHE6U346cOYHJC7iY4Xhqs8cxSs2kfiaekhxuYdxKFE0b8Per7SoPDD2cyxD6HnN0vTTRyyQGitZ19F4TkspTNl6BhGWNi8JD/zb//l4ZK3F40VK1uaMUE9Q4Vuggemz2r8mIeU1SOAykmD8N6+rgtKEf6d0IWEHJHbSmQXq9IqdAuoZzjwVh5FfUtJlZtjmKarq2COJYpfY5KTC4JxJXIlOeLnsxm7kv+ZIh9NIUVFFz9YGlT7QP4D/AhL/G1jIKijXI1tAfjjnNne6tCb8hirmI0qJtqMlOa67Bu X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(13018025)(8121501046)(13017025)(13015025)(3002001)(10201501046);SRVR:CY1PR12MB0715;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0715; X-Forefront-PRVS: 08213D42D3 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwNzE1OzIzOjlWTjQxTSt5V0NVME4rck5rZVdkbHZkV1ZU?= =?utf-8?B?ZjZLalNHbkFrVW5WUHVRWDhKemVRQ1NyK1c0R1FTeFFnMFVCbGcyd0dhSmtS?= =?utf-8?B?dm5tRWhYQXQyTXpic2d2Q0lrc2wrYUV2YzRFQ1Z0azRzUXR0bjI2SEF1RzBW?= =?utf-8?B?VHduYXAxTS91dHBYRmJjK2lXaHBVVGtOZWw3WTdLTTFoYVoxQXYzSUlyYnJC?= =?utf-8?B?VGVVampZRDhaSldQNzI5K0FzZVhJaENva1JBeHA1SVNJRXBZeStsWjg5Q0RO?= =?utf-8?B?VGZSbVYzem1xTElMaHlEeFlIU3c1QU9wK1kwQmhIWEZLVHhqNGo2K2FGamMz?= =?utf-8?B?QU1WSVYzTlA2T1laWWNpOVVRdXgvZldYQnRJRGdBQk1jWDk2WkxSRklnVVEy?= =?utf-8?B?M09mL0pOK21TdWtzbzErY0VpRVJla1RiRENxcVpvVmJkQWZNNk9YMFJnK0th?= =?utf-8?B?WXJGbFh5ODBxVHZiZ1NFaERSSmw2VklSRURmMEZnbHhiUjRYS1ZkY0pQRERx?= =?utf-8?B?RDcvKy96VVRSdXQ0V01zMndKQWFiV3lWb1ZpUDB3Smp2VXZWT2QrcGd1bHhV?= =?utf-8?B?S2daTVhiSzNtV0wyR1VZYmpkRGlkWlk5Q2VaeGowKzZkQllLSFo5NzVyMFNF?= =?utf-8?B?ZE5LNy9jRFgrM2pqd2EzSnhZdWxncXR3UllJQ1NDOG5vQWJ2YWRUcXNkUlRJ?= =?utf-8?B?a245SHQ4QkNReW1hR3NBcTI5MS9PRE1HWWF1RUIwcFh2VGM1b2ZObjJGcVlX?= =?utf-8?B?WTd2cFFwOGJZdU85UTBOdnV4andlTXd5RHZ0ZFZrRkRSeTE2eFhYUnU4ajJT?= =?utf-8?B?ang4UU4yQ21CK2VSbitKQThRNW5QY3htdGd2dklmN2hpY3ZuMTRPeTltYjEy?= =?utf-8?B?WTVNVGNRUHRqT0JUdE5EazNCaHFrQzdROXU2aGw3VE12ZFNOcFcvSnBFekRK?= =?utf-8?B?eEk4Y2dabzRaMWltT1dUK0RjVnE3NzFXMXZqZkV1a1pHMSs4UHJ6Vm1MSit4?= =?utf-8?B?a3R3cUN0RDVydFcwQmhXdFB2QW94dzRUdXR5VFRkcVRlMXhQTE16aE9oZVo1?= =?utf-8?B?YXlyTFAvc1pDT3lWQnhMOVhWMGIxaDRMZkoyQjY0Nk1YRzVvVVg4TmhOYmF5?= =?utf-8?B?dTZwUmJ5SUhTam9HOGFDM2VCTEVhc2JqbmdJTDZXWmx0NTAyUXdhMFdjSHpn?= =?utf-8?B?NTNRZ3UvenNuVHRRd3BUV2dSWElRKy9RaHN6YlB6V2RFTThWMXhRMHgwNVRU?= =?utf-8?B?RDY2d01iS3JyWTdGYjlaeld2RkpXaWtTU3lIUEJ2S013N0tZQ1NzTVJWU1da?= =?utf-8?B?c3pnSEQvbUt6dFluTTJiV2tjclpNZVVIMnBxeTVnZGtJMVNkVk5IQ2R6MDVs?= =?utf-8?B?UGZFaDdYbkt0ZjZMRTRoUU10bXdoS21LM3FGSmtqekx2WDlOY3gwTTRnbXly?= =?utf-8?B?enhGb2RoalRZbENPUjhGMUZDdlZ2bk9HNDUxQnBHL2wvZm9TWFI2TWNnSVJ0?= =?utf-8?B?eVIzQVdYQ0d1Rm52NXhGbXNjdW1VNVhnYXdreEVNanowak5wZHFaeHNxM09X?= =?utf-8?B?TnhyVXhVbUlVbVBwZHZFSjd4SkYyUXBKdFV0NDBFSllVVmNsN2FzdTNOZUJr?= =?utf-8?B?VVcrUm9rWmg3R2hFMlBxTTU1enpqWVh4eWg3ZitGZHRCazVvWXU4S2dValkw?= =?utf-8?Q?IU4m9MpSCt0PUVSkZJ/ssLHMO53qjaQ08ViWaag?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0715;5:Lhy/F4+SEio1J8PG1wc0qTt4NajpbKlHk8cqhbXQfQVflvSzwQMxs8d0/4gFqjaeaodSOHd1U+CTZ0YXGSbJxKzFiLTvEtiH9XEihzfsnSn0gAFrmsm9r2LYvz5xjStEhe4kEWxawfVZo6jhgaBWGA==;24:xMdaCTwvAayyO/W5Zsae3mWAJbiizNP4uO3xXjudwWGOnsF6qtRRkXHoQ8F3XO5RaRk+vEEuNBTVy4FJza7CLdrC65ARxHHdHvrSkwhVraU=;20:U6W+nQD+BKeCIKRSthW8z8WfagyKqq/vVz4Iyv8ngVVtTLBj8dopzkrygw4L/qEcQ3ZhVEgHZVIV36a3TNYX7K+3x0fMd21uyDOx85muKmCfFu9+HnjeSiQSDovmth6uT388COs/YzNGq0gFoDJvCfrp7W6d8+KKR3mcMul30jy9EDfFVLwLhww8y0kfdmlKLuU3NkP75tZ7OyqpewM7hVmhogULLcLc6O7gkdIbdemdlr+RWZmelCyfPanmFzPc SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2016 23:13:14.8075 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0715 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/14/2016 4:58 PM, Borislav Petkov wrote: > On Thu, Jan 14, 2016 at 04:53:58PM -0600, Aravind Gopalakrishnan wrote: >> Well McaX is name of the field in the MSR. I retained the "SMCA" prefix as > What does that McaX mean, btw? McaX indicates- * we have MCA MSRs in a new address range * there are more registers per bank (hence the definitions to registers like MCx_IPID, MCx_CONFIG etc) >> these are all still part of the ScalableMCA changes. >> I would prefer if "MCAX" is retained as it is indicative of which bit we are >> touching. So how about just MCAX_EN_OFF ? > If we're going to have a bunch of defines belonging to SMCA, then we're > better having them all start with SMCA_ after all, I guess. > > But please make sure you have comments over their definitions explaining > what those bits are. When an outsider is reading those patches and SMCA, > MCAX start appearing left and right, his head most likely starts to > spin. > Sure, I shall add some comments around the definitions for V2. Thanks, -Aravind.