From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751283AbcAOBbL (ORCPT ); Thu, 14 Jan 2016 20:31:11 -0500 Received: from muin.pair.com ([209.68.1.55]:50277 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbcAOBbJ (ORCPT ); Thu, 14 Jan 2016 20:31:09 -0500 Subject: Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options To: Nicolin Chen , Caleb Crome Cc: Xiubo Li , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org References: <1452788982-11583-1-git-send-email-caleb@crome.org> <20160114201858.GA17567@Asurada-Nvidia> From: Timur Tabi Message-ID: <56984BE7.2050303@tabi.org> Date: Thu, 14 Jan 2016 19:31:19 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 MIME-Version: 1.0 In-Reply-To: <20160114201858.GA17567@Asurada-Nvidia> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nicolin Chen wrote: > I think DT maintainers may not give a consent towards these two > properties as they are not to describe the hardware but to hack > software configurations. (And it seems you haven't CCed them.) I admit it's a grey area, but the hardware doesn't work if you use the wrong value, and it is a fixed value per device. A p1022ds would use a different value than in in i.MX6, and once you pick a value, it's the same no matter which sample rate, buffer size, etc you choose.