From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757463AbcAOKmx (ORCPT ); Fri, 15 Jan 2016 05:42:53 -0500 Received: from regular1.263xmail.com ([211.150.99.131]:59027 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754933AbcAOKmD (ORCPT ); Fri, 15 Jan 2016 05:42:03 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:S;ATT:S;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-MAE-MAIL_UID: 005698ccf00052db@maes@068b82e1969f2b90 X-MAE-ID: 223.6.254.61 X-RL-SENDER: andy.yan@rock-chips.com X-LOGIN-NAME: andy.yan@rock-chips.com X-SENDER-IP: 121.15.173.1 Subject: Re: [PATCH 2/2] ARM: dts: rockchip: enable pwm3 as pwm regulator for rk3066a-rayeager board To: Heiko Stuebner References: <1452774780-16493-1-git-send-email-andy.yan@rock-chips.com> <1452774956-16621-1-git-send-email-andy.yan@rock-chips.com> <2237362.fjXobafQhV@phil> Cc: naobsd@gmail.com, robh+dt@kernel.org, linux@arm.linux.org.uk, devicetree@vger.kernel.org, galak@codeaurora.org, linux-kernel@vger.kernel.org, ijc+devicetree@hellion.org.uk, linux-rockchip@lists.infradead.org, pawel.moll@arm.com, mark.rutland@arm.com, inux-arm-kernel@lists.infradead.org From: Andy Yan Message-ID: <5698CCF0.8040406@rock-chips.com> Date: Fri, 15 Jan 2016 18:41:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <2237362.fjXobafQhV@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko: On 2016年01月14日 20:41, Heiko Stuebner wrote: > Hi Andy, > > Am Donnerstag, 14. Januar 2016, 20:35:56 schrieb Andy Yan: >> Rayeager board use pwm3 modulate the vdd_logic voltage, so enable it. >> >> Signed-off-by: Andy Yan >> --- >> >> arch/arm/boot/dts/rk3066a-rayeager.dts | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3066a-rayeager.dts >> b/arch/arm/boot/dts/rk3066a-rayeager.dts index 3d4c104..d17a5b8 100644 >> --- a/arch/arm/boot/dts/rk3066a-rayeager.dts >> +++ b/arch/arm/boot/dts/rk3066a-rayeager.dts >> @@ -78,6 +78,18 @@ >> }; >> }; >> >> + pwm_regulator: pwm-regulator { >> + compatible = "pwm-regulator"; >> + pwms = <&pwm3 0 1000>; >> + regulator-name = "vdd_logic"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; > I guess this is to make sure it stays at 1.2V at all times, or is the min- > microvolt settings supposed to be lower? > > > Thanks > Heiko > > > Yes, I want to fix it at 1.2V. When I read the regulator_register function, I found it call regulator_do_set_voltate only when min=max. So I set it like what you see. regulator_register---> set_machine_constrains---> machine_constrains_voltage-->