From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbcAONqg (ORCPT ); Fri, 15 Jan 2016 08:46:36 -0500 Received: from muin.pair.com ([209.68.1.55]:54548 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbcAONqe (ORCPT ); Fri, 15 Jan 2016 08:46:34 -0500 Subject: Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options To: Mark Brown Cc: Nicolin Chen , Caleb Crome , Xiubo Li , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org References: <1452788982-11583-1-git-send-email-caleb@crome.org> <20160114201858.GA17567@Asurada-Nvidia> <56984BE7.2050303@tabi.org> <20160115131325.GW6588@sirena.org.uk> From: Timur Tabi Message-ID: <5698F846.5080604@tabi.org> Date: Fri, 15 Jan 2016 07:46:46 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 MIME-Version: 1.0 In-Reply-To: <20160115131325.GW6588@sirena.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Brown wrote: >> >I admit it's a grey area, but the hardware doesn't work if you use the wrong >> >value, and it is a fixed value per device. A p1022ds would use a different >> >value than in in i.MX6, and once you pick a value, it's the same no matter >> >which sample rate, buffer size, etc you choose. > Caleb's original message suggested this was rate dependant. Yeah, I just noticed that. In that case, I agree that a device tree property is inappropriate, unless it's an array that contains tuples of sample rates and watermark/maxburst settings. That would get unwieldy very easily, though.