From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754027AbcAOQck (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jan 2016 11:32:40 -0500
Received: from [195.59.15.196] ([195.59.15.196]:38961 "EHLO
	mailapp01.imgtec.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org
	with ESMTP id S1750762AbcAOQci (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jan 2016 11:32:38 -0500
Message-ID: <56991F23.8010500@imgtec.com>
Date: Fri, 15 Jan 2016 16:32:35 +0000
From: James Hartley <james.hartley@imgtec.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2
MIME-Version: 1.0
To: Philipp Zabel <p.zabel@pengutronix.de>
CC: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Damien Horsley <damien.horsley@imgtec.com>,
        Govindraj Raja <govindraj.raja@imgtec.com>
Subject: Re: [PATCH 1/2] reset: img: Add pistachio reset controller binding
 document
References: <1452869073-27608-1-git-send-email-james.hartley@imgtec.com>  <1452869073-27608-2-git-send-email-james.hartley@imgtec.com> <1452873439.6067.86.camel@pengutronix.de>
In-Reply-To: <1452873439.6067.86.camel@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [192.168.167.85]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Philipp,

Thanks for the quick review,

On 01/15/16 15:57, Philipp Zabel wrote:
> Am Freitag, den 15.01.2016, 14:44 +0000 schrieb James Hartley:
[..]
>> +Example:
>> +
>> +	pistachio_reset: reset-controller {
>> +		compatible = "img,pistachio-reset";
>> +		img,cr-periph = <&cr_periph>;
>> +		#reset-cells = <1>;
>> +	};
> If this is just a register in the cr_periph syscon, why not put the
> reset-controller node inside the cr_periph node:
>
>      cr_periph: syscon@xyz {
>          compatible = "syscon", "simple-mfd";
>          pistachio_reset: reset-controller {
>              compatible = "img,pistachio-reset";
>              #reset-cells = <1>;
>          };
>      };
>
> And in the driver use
>      syscon_node_to_regmap(np->parent);
> instead of
>      syscon_regmap_lookup_by_phandle(np, "img,cr-periph");
> ?

Yes that makes sense, I'll look at changing that for a V2 patchset.

> Do you need a reg property, or is will the register offset be 0 in all
> pistachio variants?

The offset will always be 0 for all pistachio variants.

[..]
> +Example:
> +
> +	spdif_out: spdif-out@18100d00 {
> +		...
> +		resets = <&pistachio_reset PISTACHIO_RESET_SPDIF_OUT>;
> +		reset-names = "rst";
> reset-names is not needed for devices that only have one reset.

Agreed, but there are already audio drivers that pistachio uses that 
have been merged upstream
using this name in their dt-entries - is there any harm in leaving it in?

>
> regards
> Philipp
>
Thanks,
James.