From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753491AbcAORFZ (ORCPT ); Fri, 15 Jan 2016 12:05:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:57088 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbcAORFX (ORCPT ); Fri, 15 Jan 2016 12:05:23 -0500 Subject: Re: [PATCH V12 2/7] dma: hidma: Add Device Tree support To: Mark Rutland References: <1452523550-8920-1-git-send-email-okaya@codeaurora.org> <1452523550-8920-3-git-send-email-okaya@codeaurora.org> <20160115151637.GJ3262@leverpostej> <20160115153054.GL3262@leverpostej> Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, vinod.koul@intel.com, jcm@redhat.com, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: <569926CF.6030205@codeaurora.org> Date: Fri, 15 Jan 2016 12:05:19 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160115153054.GL3262@leverpostej> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/15/2016 10:30 AM, Mark Rutland wrote: > Further to my reply below, I'm generally uncomfortable with some > properties (max-* need a better description if they are a HW > requirement, and probably should not be present otherwise). I'll add more description. > I'm also > concerned that information necessary for the advertised use-case of the > device (e.g. IOMMUs) is missing [1], and we're missing parts of the > story necessary to review this for correctness. OK. Let me work on this. I tried to capture as much documentation as possible into the series before. One reviewer said I should add it. Another reviewer said I should remove it. Where would be the best place to document the use case? - In the source file? - In the commit message? - In the device-tree documentation? I'll try to write up something based on your and Mark Zyngier's questions for the next release. > > Until that's settled, I don't think this is ready yet, and I don't think > this should be picked up. > > I'm sorry to say that at this stage, as I realise that may sound > obstructive. That's not my intention, and I hope we can figure out those > details quickly. I hope so too. I'm going towards V20 with small nitpicks rather than the good feedback like yours. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project