From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
konrad.wilk@oracle.com, david.vrabel@citrix.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack
Date: Fri, 15 Jan 2016 14:53:02 -0500 [thread overview]
Message-ID: <56994E1E.2070000@oracle.com> (raw)
In-Reply-To: <56994D79.1010702@citrix.com>
On 01/15/2016 02:50 PM, Andrew Cooper wrote:
> On 15/01/16 19:43, Boris Ostrovsky wrote:
>> @@ -933,18 +937,20 @@ static long gntdev_ioctl_grant_copy(struct gntdev_priv *priv, void __user *u)
>> goto out;
>> }
>>
>> - ret = gntdev_grant_copy_seg(&batch, &seg, ©.segments[i].status);
>> + ret = gntdev_grant_copy_seg(batch, &seg,
>> + ©.segments[i].status);
>> if (ret < 0)
>> goto out;
>>
>> cond_resched();
>> }
>> - if (batch.nr_ops)
>> - ret = gntdev_copy(&batch);
>> + if (batch->nr_ops)
>> + ret = gntdev_copy(batch);
> You presumably want a kfree() here?
Ah, missed it. Thanks.
>
>> return ret;
>>
next prev parent reply other threads:[~2016-01-15 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 19:43 [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack Boris Ostrovsky
2016-01-15 19:50 ` [Xen-devel] " Andrew Cooper
2016-01-15 19:53 ` Boris Ostrovsky [this message]
2016-01-18 11:11 ` David Vrabel
2016-01-19 14:26 ` Boris Ostrovsky
2016-01-19 14:31 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56994E1E.2070000@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).