From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926AbcAOTxA (ORCPT ); Fri, 15 Jan 2016 14:53:00 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:48192 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbcAOTw6 (ORCPT ); Fri, 15 Jan 2016 14:52:58 -0500 Subject: Re: [Xen-devel] [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack To: Andrew Cooper , konrad.wilk@oracle.com, david.vrabel@citrix.com References: <1452887025-27285-1-git-send-email-boris.ostrovsky@oracle.com> <56994D79.1010702@citrix.com> Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: <56994E1E.2070000@oracle.com> Date: Fri, 15 Jan 2016 14:53:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <56994D79.1010702@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/15/2016 02:50 PM, Andrew Cooper wrote: > On 15/01/16 19:43, Boris Ostrovsky wrote: >> @@ -933,18 +937,20 @@ static long gntdev_ioctl_grant_copy(struct gntdev_priv *priv, void __user *u) >> goto out; >> } >> >> - ret = gntdev_grant_copy_seg(&batch, &seg, ©.segments[i].status); >> + ret = gntdev_grant_copy_seg(batch, &seg, >> + ©.segments[i].status); >> if (ret < 0) >> goto out; >> >> cond_resched(); >> } >> - if (batch.nr_ops) >> - ret = gntdev_copy(&batch); >> + if (batch->nr_ops) >> + ret = gntdev_copy(batch); > You presumably want a kfree() here? Ah, missed it. Thanks. > >> return ret; >>