From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753477AbcAOVCH (ORCPT ); Fri, 15 Jan 2016 16:02:07 -0500 Received: from mga01.intel.com ([192.55.52.88]:47821 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbcAOVCF (ORCPT ); Fri, 15 Jan 2016 16:02:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,301,1449561600"; d="scan'208";a="634103533" Subject: Re: [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing To: Yu-cheng Yu , Borislav Petkov References: <1452119094-7252-2-git-send-email-yu-cheng.yu@intel.com> <20160115202858.GK25104@pd.tnic> <20160115205035.GA32625@test-lenovo> Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, torvalds@linux-foundation.org, tglx@linutronix.de, oleg@redhat.com, ravi.v.shankar@intel.com, fenghua.yu@intel.com, mingo@kernel.org, quentin.casasnovas@oracle.com, bp@suse.de, hpa@zytor.com, luto@amacapital.net, sai.praneeth.prakhya@intel.com, linux-tip-commits@vger.kernel.org From: Dave Hansen Message-ID: <56995E31.6040202@linux.intel.com> Date: Fri, 15 Jan 2016 13:01:37 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160115205035.GA32625@test-lenovo> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/15/2016 12:50 PM, Yu-cheng Yu wrote: >> > >> > This could certainly be improved: we're iterating over the *whole* >> > command line each time for each option unconditionally instead of >> > iterating word by word and comparing it with all strings. >> > >> > We'd need something like cmdline_for_each_word() or so, though... >> > > That is a good point. I will work on it. I really don't think we need to do this. It's code that runs *ONCE* at boot time. Let's not work on optimizing it unless we have some acute need.