From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbcAOXmJ (ORCPT ); Fri, 15 Jan 2016 18:42:09 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35690 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834AbcAOXmH (ORCPT ); Fri, 15 Jan 2016 18:42:07 -0500 Subject: Re: [RFC 26/29] dma-buf/fence: remove pointless fence_timeline_signal at destroy phase To: Gustavo Padovan , John Harrison References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> <1452869739-3304-27-git-send-email-gustavo@padovan.org> <569930FF.1090601@Intel.com> <20160115180207.GD2664@joana> Cc: Gustavo Padovan , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , Rob Clark , Maarten Lankhorst , tomcherry@google.com, dtor@google.com From: Greg Hackmann Message-ID: <569983CC.7000207@google.com> Date: Fri, 15 Jan 2016 15:42:04 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160115180207.GD2664@joana> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/15/2016 10:02 AM, Gustavo Padovan wrote: > Patches 27 and 28 are attempt to fix that. I assumed that if some code is > calling fence_timeline_destroy() it wants to stop everything so I > worked on a solution that stops any waiter and allows the timeline to be > destroyed. > > No one is using fence_timeline_destroy() in mainline now, so it is > definately a behaviour we can discuss. > > Gustavo > +Tom Cherry and Dmitry Torokhov recently discovered that this was broken by the refactoring of Android sync on top of dma-buf fences. Tom and Dmitry, did you send the proposed fix upstream?