From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757AbcAPUcw (ORCPT ); Sat, 16 Jan 2016 15:32:52 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36792 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbcAPUct (ORCPT ); Sat, 16 Jan 2016 15:32:49 -0500 Subject: Re: [RESEND PATCH 0/2] crypto: sunxi-ss: fix 64-bit compilation To: Andre Przywara , Maxime Ripard , Chen-Yu Tsai , Arnd Bergmann References: <1452252249-12040-1-git-send-email-andre.przywara@arm.com> Cc: Herbert Xu , "David S . Miller" , linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org From: Corentin LABBE Message-ID: <569AA8ED.7050404@gmail.com> Date: Sat, 16 Jan 2016 21:32:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1452252249-12040-1-git-send-email-andre.przywara@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 08/01/2016 12:24, Andre Przywara a écrit : > (resending to add linux-crypto, patches unchanged) > > Hi, > > these two patches provide a different approach to an issue I tried > to fix lately [1]. > Instead of casting everything I now promote local types to size_t, so > that the min3() arguments naturally match in type. > As size_t is defined as "unsigned int" on 32-bit architectures > anyway, that actually does not change anything there, but instead > provides a clean approach to get it compiled for arm64. > > I split this up because 1/2 seems much cleaner to me than 2/2, so we > can have a separate discussion/merge process on this. > > Cheers, > Andre. > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/395689.html > > Andre Przywara (2): > crypto: sunxi-ss-cipher: promote variables to match types in min3() > calls > crypto: sunxi-ss-hash: promote variables to match types in min3() > calls > > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 20 ++++++++++---------- > drivers/crypto/sunxi-ss/sun4i-ss-hash.c | 12 ++++++------ > drivers/crypto/sunxi-ss/sun4i-ss.h | 2 +- > 3 files changed, 17 insertions(+), 17 deletions(-) > Hello Sorry for this late answer. I am in trouble with those patch, so we have with Andre a long conversation about it. Basically, sun4i-ss will never be available on 64bits platform. (A64 will have a totally new crypto engine). So letting it to compile under 64bit arch is only useful when goal is to add COMPILE_TEST for it. But COMPILE_TEST cannot simply be added with those patch since some arches (x86/x86_64 at least) does not have writesl/readsl available. The conclusion is that it is simpler to block 64bit build for sun4i-ss. Regards LABBE Corentin