From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbcAREYR (ORCPT ); Sun, 17 Jan 2016 23:24:17 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:10349 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973AbcAREXi (ORCPT ); Sun, 17 Jan 2016 23:23:38 -0500 X-AuditID: cbfec7f5-f79b16d000005389-ad-569c68c7c9a9 Subject: Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx series RTC IP To: Mark Brown References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-6-git-send-email-ldewangan@nvidia.com> <569594F0.4020007@samsung.com> <5695CD73.5010709@nvidia.com> <5695D268.3060705@samsung.com> <5695D1AF.9000806@nvidia.com> <5696665A.5030508@nvidia.com> <5696F0C4.1060904@samsung.com> <5696F7F8.108@samsung.com> <20160114142048.GS6588@sirena.org.uk> Cc: Laxman Dewangan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com From: Krzysztof Kozlowski Message-id: <569C68BE.3030804@samsung.com> Date: Mon, 18 Jan 2016 13:23:26 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <20160114142048.GS6588@sirena.org.uk> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t/xa7rHM+aEGez9ymSx5OJVdouOa4uZ LKY+fMJmMf/IOVaL/jcLWS3OvXrEAiRWMlq8fmFosXTfahaL+1+PMlp8u9LBZDHlz3Imi83z /zBaXN41h81i6fWLTBYTpq9lsWjde4TdYn9nB6PFjektrBa3f/M5iHismbeG0eNyXy+Tx5NN Fxk9ds66y+6xZ+JJNo+Vy7+weWxa1cnmcefaHjaP3uZ3bB59W1Yxekyf95PJ4/MmuQCeKC6b lNSczLLUIn27BK6MnvYeloIm9oof7c/YGhjPsXYxcnJICJhI3FqyjhnCFpO4cG89WxcjF4eQ wFJGiRdvprJDOE8ZJU4ua2UDqRIWiJF4sXouC4gtIqAscfX7XhaIov9MEucXXQJzmAVuMEuc en8ArIpNwFhi8/IlYN28AloSfVv/MIHYLAKqEpcbb7CD2KICERKHO7vYIWoEJX5MvgfWyylg JLHj3VGgeg6goXoS9y9qgYSZBeQlNq95yzyBUWAWko5ZCFWzkFQtYGRexSiaWppcUJyUnmuk V5yYW1yal66XnJ+7iRESq193MC49ZnWIUYCDUYmH1+Hs7DAh1sSy4srcQ4wSHMxKIrzSKXPC hHhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+REggPbEkNTs1tSC1CCbLxMEp1cDo+nnOhz+7 Xt2Q91bUm8bJ0Xpq276ltT3Lzrn83Os3ZZX9y+aV020+7PTJuHv03641NuEs6ZxPxQ1mRzpU 7M/Yv9A76vkun/z5RuWiFYdlDnWxXZY7LPhdWkVD02oVZ8eFu1GXrzxl/njG3lvlhp7rnCkG lwPrEmdXH+zhneX/t1dPQon1/u9rSizFGYmGWsxFxYkAZoLcwtECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.01.2016 23:20, Mark Brown wrote: > On Thu, Jan 14, 2016 at 10:20:56AM +0900, Krzysztof Kozlowski wrote: > >> 2. It has different register address. >> We need a register-layout/configuration structure. The logic is the >> same except few differences (e.g. presence of MAX77802_RTC_AE1). > > Depending on what the differences are either just some variables in the > driver data that get set on probe with the different registers (if it's > just the register) or using regmap_field (if things get shifted as well, > or if it happens to make more sense) should work. Thanks for the hints! The addresses for registers are indeed shifted. It is non-linear because apart of different offset at beginning, a new field appears. Anyway it would be good for me (or other person doing this work) to get more knowledge of what regmap API provides. Best regards, Krzysztof