From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754516AbcARKlp (ORCPT ); Mon, 18 Jan 2016 05:41:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35828 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753953AbcARKln (ORCPT ); Mon, 18 Jan 2016 05:41:43 -0500 Subject: Re: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts To: "Wu, Feng" , =?UTF-8?Q?Radim_Krcm=c3=a1r?= References: <1450229853-3886-1-git-send-email-feng.wu@intel.com> <1450229853-3886-2-git-send-email-feng.wu@intel.com> <20151223171932.GB7061@potion.redhat.com> Cc: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Paolo Bonzini Message-ID: <569CC162.6090207@redhat.com> Date: Mon, 18 Jan 2016 11:41:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/01/2016 06:19, Wu, Feng wrote: > However, > this will make the vector-hashing lowest-priority handling slightly different > compare to round-robin, since RR checks "!dst[i]" before injecting the > interrupts. What is your opinion about it? Thanks a lot! I think Radim's suggestion is fine. You can print an error (just once per guest) to dmesg if the result of the hashing computation corresponds to a disabled APIC. Paolo